Tighten types in test.dart even more.

tools/testing/dart/test_progress.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_progress;
 
 import "dart:convert" show JSON;
 import "dart:io";
 
 import "expectation.dart";
+import "http_server.dart";
 import "path.dart";
 import "summary_report.dart";
 import "test_runner.dart";
 import "test_suite.dart";
 import "utils.dart";
 
 /// Controls how message strings are processed before being displayed.
 class Formatter {
   /// Messages are left as-is.
   static const normal = const Formatter._();
@@ skipping 181 matching lines @@
   }
 }
 
 class UnexpectedCrashLogger extends EventListener {
   final archivedBinaries = <String, String>{};
 
   void done(TestCase test) {
     if (test.unexpectedOutput &&
         test.result == Expectation.crash &&
         test.lastCommandExecuted is ProcessCommand) {
-      final pid = "${test.lastCommandOutput.pid}";
-      final lastCommand = test.lastCommandExecuted as ProcessCommand;
+      var pid = "${test.lastCommandOutput.pid}";
+      var lastCommand = test.lastCommandExecuted as ProcessCommand;
 
       // We might have a coredump for the process. This coredump will be
       // archived by CoreDumpArchiver (see tools/utils.py).
       //
       // For debugging purposes we need to archive the crashed binary as well.
       //
       // To simplify the archiving code we simply copy binaries into current
       // folder next to core dumps and name them
       // `binary.${mode}_${arch}_${binary_name}`.
-      final binName = lastCommand.executable;
-      final binFile = new File(binName);
-      final binBaseName = new Path(binName).filename;
+      var binName = lastCommand.executable;
+      var binFile = new File(binName);
+      var binBaseName = new Path(binName).filename;
       if (!archivedBinaries.containsKey(binName) && binFile.existsSync()) {
-        final mode = test.configuration['mode'];
-        final arch = test.configuration['arch'];
-        final archived = "binary.${mode}_${arch}_${binBaseName}";
+        var mode = test.configuration['mode'] as String;
+        var arch = test.configuration['arch'] as String;
+        var archived = "binary.${mode}_${arch}_${binBaseName}";
         TestUtils.copyFile(new Path(binName), new Path(archived));
         archivedBinaries[binName] = archived;
       }
 
       if (archivedBinaries.containsKey(binName)) {
         // We have found and copied the binary.
         RandomAccessFile unexpectedCrashesFile;
         try {
           unexpectedCrashesFile =
               new File('unexpected-crashes').openSync(mode: FileMode.APPEND);
@@ skipping 364 matching lines @@
     if (test.commandOutputs.length != test.commands.length &&
         !test.expectCompileError) {
       output.add('Unexpected compile-time error.');
     } else {
       if (test.expectCompileError) {
         output.add('Compile-time error expected.');
       }
       if (test.hasRuntimeError) {
         output.add('Runtime error expected.');
       }
-      if (test.configuration['checked'] && test.isNegativeIfChecked) {
+      if ((test.configuration['checked'] as bool) && test.isNegativeIfChecked) {
         output.add('Dynamic type error expected.');
       }
     }
   }
 
   for (var i = 0; i < test.commands.length; i++) {
     var command = test.commands[i];
     var commandOutput = test.commandOutputs[command];
     if (commandOutput != null) {
       output.add("CommandOutput[${command.displayName}]:");
@@ skipping 12 matching lines @@
       if (!commandOutput.stderr.isEmpty) {
         output.add('');
         output.add('stderr:');
         output.addAll(_linesWithoutCarriageReturn(commandOutput.stderr));
       }
     }
   }
 
   if (test is BrowserTestCase) {
     // Additional command for rerunning the steps locally after the fact.
-    var command = test.configuration["_servers_"].httpServerCommandLine();
+    var command = (test.configuration["_servers_"] as TestingServers)
+        .httpServerCommandLine();
     output.add('');
     output.add('To retest, run:  $command');
   }
 
   for (var i = 0; i < test.commands.length; i++) {
     var command = test.commands[i];
     var commandOutput = test.commandOutputs[command];
     output.add('');
     output.add('Command[${command.displayName}]: $command');
     if (commandOutput != null) {
       output.add('Took ${commandOutput.time}');
     } else {
       output.add('Did not run');
     }
   }
 
   var arguments = ['python', 'tools/test.py'];
-  arguments.addAll(test.configuration['_reproducing_arguments_']);
+  arguments
+      .addAll(test.configuration['_reproducing_arguments_'] as List<String>);

[Siggi Cherem (dart-lang), 2017/05/30 20:48:39]

here too?

[Bob Nystrom, 2017/05/30 21:01:46]

This one is OK. It comes from _reproducingCommand(), which does return a reified
List<String>.

   arguments.add(test.displayName);
   var testPyCommandline = arguments.map(escapeCommandLineArgument).join(' ');
 
   output.add('');
   output.add('Short reproduction command (experimental):');
   output.add("    $testPyCommandline");
   return output;
 }
 
 String _buildSummaryEnd(int failedTests) {
   if (failedTests == 0) {
     return '\n===\n=== All tests succeeded\n===\n';
   } else {
     var pluralSuffix = failedTests != 1 ? 's' : '';
     return '\n===\n=== ${failedTests} test$pluralSuffix failed\n===\n';
   }
 }