Tighten types in test.dart even more.

tools/testing/dart/test_configurations.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_configurations;
 
 import "dart:async";
 import 'dart:convert';
 import 'dart:io';
 import "dart:math" as math;
@@ skipping 40 matching lines @@
   new Path('tests/lib_strong'),
   new Path('tests/standalone'),
   new Path('tests/utils'),
   new Path('utils/tests/css'),
   new Path('utils/tests/peg'),
 ];
 
 // This file is created by gclient runhooks.
 final VS_TOOLCHAIN_FILE = new Path("build/win_toolchain.json");
 
-Future testConfigurations(List<Map> configurations) async {
+Future testConfigurations(List<Map<String, dynamic>> configurations) async {
   var startTime = new DateTime.now();
   // Extract global options from first configuration.
   var firstConf = configurations[0];
   var maxProcesses = firstConf['tasks'] as int;
-  var progressIndicator = firstConf['progress'];
-  BuildbotProgressIndicator.stepName = firstConf['step_name'];
-  var verbose = firstConf['verbose'];
-  var printTiming = firstConf['time'];
-  var listTests = firstConf['list'];
+  var progressIndicator = firstConf['progress'] as String;
+  BuildbotProgressIndicator.stepName = firstConf['step_name'] as String;
+  var verbose = firstConf['verbose'] as bool;
+  var printTiming = firstConf['time'] as bool;
+  var listTests = firstConf['list'] as bool;
 
-  var reportInJson = firstConf['report_in_json'];
+  var reportInJson = firstConf['report_in_json'] as bool;
 
-  var recordingPath = firstConf['record_to_file'];
-  var recordingOutputPath = firstConf['replay_from_file'];
+  var recordingPath = firstConf['record_to_file'] as String;
+  var recordingOutputPath = firstConf['replay_from_file'] as String;
 
-  Browser.resetBrowserConfiguration = firstConf['reset_browser_configuration'];
+  Browser.resetBrowserConfiguration =
+      firstConf['reset_browser_configuration'] as bool;
 
   if (recordingPath != null && recordingOutputPath != null) {
     print("Fatal: Can't have the '--record_to_file' and '--replay_from_file'"
         "at the same time. Exiting ...");
     exit(1);
   }
 
-  if (!firstConf['append_logs']) {
+  if (!(firstConf['append_logs'] as bool)) {
     var files = [
       new File(TestUtils.flakyFileName),
       new File(TestUtils.testOutcomeFileName)
     ];
     for (var file in files) {
       if (file.existsSync()) {
         file.deleteSync();
       }
     }
   }
 
   DebugLogger.init(
-      firstConf['write_debug_log'] ? TestUtils.debugLogFilePath : null,
-      append: firstConf['append_logs']);
+      firstConf['write_debug_log'] as bool ? TestUtils.debugLogFilePath : null,
+      append: firstConf['append_logs'] as bool);
 
   // Print the configurations being run by this execution of
   // test.dart. However, don't do it if the silent progress indicator
   // is used. This is only needed because of the junit tests.
   if (progressIndicator != 'silent') {
     var outputWords = configurations.length > 1
         ? ['Test configurations:']
         : ['Test configuration:'];
     for (Map conf in configurations) {
       List settings = ['compiler', 'runtime', 'mode', 'arch']
           .map((name) => conf[name])
           .toList();
-      if (conf['checked']) settings.add('checked');
-      if (conf['strong']) settings.add('strong');
+      if (conf['checked'] as bool) settings.add('checked');
+      if (conf['strong'] as bool) settings.add('strong');
       outputWords.add(settings.join('_'));
     }
     print(outputWords.join(' '));
   }
 
   var runningBrowserTests = configurations.any((config) {
-    return TestUtils.isBrowserRuntime(config['runtime']);
+    return TestUtils.isBrowserRuntime(config['runtime'] as String);
   });
 
   List<Future> serverFutures = [];
   var testSuites = <TestSuite>[];
   var maxBrowserProcesses = maxProcesses;
   if (configurations.length > 1 &&
       (configurations[0]['test_server_port'] != 0 ||
           configurations[0]['test_server_cross_origin_port'] != 0)) {
     print("If the http server ports are specified, only one configuration"
         " may be run at a time");
     exit(1);
   }
   for (var conf in configurations) {
-    Map<String, RegExp> selectors = conf['selectors'];
-    var useContentSecurityPolicy = conf['csp'];
+    var selectors = conf['selectors'] as Map<String, RegExp>;
+    var useContentSecurityPolicy = conf['csp'] as bool;
     if (!listTests && runningBrowserTests) {
       // Start global http servers that serve the entire dart repo.
       // The http server is available on window.location.port, and a second
       // server for cross-domain tests can be found by calling
       // getCrossOriginPortNumber().
       var servers = new TestingServers(
           TestUtils.buildDir(conf),
           useContentSecurityPolicy,
-          conf['runtime'],
+          conf['runtime'] as String,
           null,
-          conf['package_root'],
-          conf['packages']);
-      serverFutures.add(servers.startServers(conf['local_ip'],
-          port: conf['test_server_port'],
-          crossOriginPort: conf['test_server_cross_origin_port']));
+          conf['package_root'] as String,
+          conf['packages'] as String);
+      serverFutures.add(servers.startServers(conf['local_ip'] as String,
+          port: conf['test_server_port'] as int,
+          crossOriginPort: conf['test_server_cross_origin_port'] as int));
       conf['_servers_'] = servers;
       if (verbose) {
         serverFutures.last.then((_) {
           var commandline = servers.httpServerCommandLine();
           print('Started HttpServers: $commandline');
         });
       }
     }
 
-    if (conf['runtime'].startsWith('ie')) {
+    if ((conf['runtime'] as String).startsWith('ie')) {
       // NOTE: We've experienced random timeouts of tests on ie9/ie10. The
       // underlying issue has not been determined yet. Our current hypothesis
       // is that windows does not handle the IE processes independently.
       // If we have more than one browser and kill a browser we are seeing
       // issues with starting up a new browser just after killing the hanging
       // browser.
       maxBrowserProcesses = 1;
-    } else if (conf['runtime'].startsWith('safari')) {
+    } else if ((conf['runtime'] as String).startsWith('safari')) {
       // Safari does not allow us to run from a fresh profile, so we can only
       // use one browser. Additionally, you can not start two simulators
       // for mobile safari simultainiously.
       maxBrowserProcesses = 1;
-    } else if (conf['runtime'] == 'chrome' &&
+    } else if ((conf['runtime'] as String) == 'chrome' &&
         Platform.operatingSystem == 'macos') {
       // Chrome on mac results in random timeouts.
       // Issue: https://github.com/dart-lang/sdk/issues/23891
       // This change does not fix the problem.
       maxBrowserProcesses = math.max(1, maxBrowserProcesses ~/ 2);
-    } else if (conf['runtime'] != 'drt') {
+    } else if ((conf['runtime'] as String) != 'drt') {
       // Even on machines with more than 16 processors, don't open more
       // than 15 browser instances, to avoid overloading the machine.
       // This is especially important when running locally on powerful
       // desktops.
       maxBrowserProcesses = math.min(maxBrowserProcesses, 15);
     }
 
     // If we specifically pass in a suite only run that.
     if (conf['suite_dir'] != null) {
-      var suite_path = new Path(conf['suite_dir']);
+      var suite_path = new Path(conf['suite_dir'] as String);
       testSuites.add(new PKGTestSuite(conf, suite_path));
     } else {
       for (final testSuiteDir in TEST_SUITE_DIRECTORIES) {
         final name = testSuiteDir.filename;
         if (selectors.containsKey(name)) {
           testSuites
               .add(new StandardTestSuite.forDirectory(conf, testSuiteDir));
         }
       }
       for (String key in selectors.keys) {
         if (key == 'co19') {
           testSuites.add(new Co19TestSuite(conf));
         } else if ((conf['compiler'] == 'dartk' ||
                 conf['compiler'] == 'none') &&
             conf['runtime'] == 'vm' &&
             key == 'vm') {
           // vm tests contain both cc tests (added here) and dart tests (added
           // in [TEST_SUITE_DIRECTORIES]).
           testSuites.add(new VMTestSuite(conf));
-        } else if (conf['analyzer']) {
+        } else if (conf['analyzer'] as bool) {
           if (key == 'analyze_library') {
             testSuites.add(new AnalyzeLibraryTestSuite(conf));
           }
         }
       }
     }
   }
 
   void allTestsFinished() {
     for (var conf in configurations) {
@@ skipping 29 matching lines @@
       var printFailureSummary = progressIndicator != 'buildbot';
       eventListener.add(new TestFailurePrinter(printFailureSummary, formatter));
     }
     eventListener.add(
         ProgressIndicator.fromName(progressIndicator, startTime, formatter));
     if (printTiming) {
       eventListener.add(new TimingPrinter(startTime));
     }
     eventListener.add(new SkippedCompilationsPrinter());
   }
-  if (firstConf['write_test_outcome_log']) {
+  if (firstConf['write_test_outcome_log'] as bool) {
     eventListener.add(new TestOutcomeLogWriter());
   }
-  if (firstConf['copy_coredumps']) {
+  if (firstConf['copy_coredumps'] as bool) {
     eventListener.add(new UnexpectedCrashLogger());
   }
 
   // The only progress indicator when listing tests should be the
   // the summary printer.
   if (listTests) {
     eventListener.add(new SummaryPrinter(jsonOnly: reportInJson));
   } else {
     eventListener.add(new ExitCodeSetter());
     eventListener.add(new IgnoredTestMonitor());
   }
 
   // If any of the configurations need to access android devices we'll first
   // make a pool of all available adb devices.
   AdbDevicePool adbDevicePool;
-  bool needsAdbDevicePool = configurations.any((Map conf) {
+  var needsAdbDevicePool = configurations.any((Map conf) {
     return conf['runtime'] == 'dart_precompiled' && conf['system'] == 'android';
   });
   if (needsAdbDevicePool) {
     adbDevicePool = await AdbDevicePool.create();
   }
 
   // Start all the HTTP servers required before starting the process queue.
   if (!serverFutures.isEmpty) {
     await Future.wait(serverFutures);
   }
@@ skipping 19 matching lines @@
       maxBrowserProcesses,
       startTime,
       testSuites,
       eventListener,
       allTestsFinished,
       verbose,
       recordingPath,
       recordingOutputPath,
       adbDevicePool);
 }