Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2903693004: Make PageLoadMetricsWaiter more resilient (Closed)
Patch Set: fix compile Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index 197a9884df341e6bd7de16e171152d58f6d6aa3d..abd5ffaef8718aedb971b6cf384c055f77f5c0b9 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -336,13 +336,16 @@ class PageLoadMetricsObserver {
// tracked at the time a navigation commits will not receive any of the
// callbacks below.
- // OnTimingUpdate is triggered when an updated PageLoadTiming is
- // available. This method may be called multiple times over the course of the
- // page load. This method is currently only intended for use in testing. Most
- // implementers should implement one of the On* callbacks, such as
- // OnFirstContentfulPaint or OnDomContentLoadedEventStart. Please email
- // loading-dev@chromium.org if you intend to override this method.
- virtual void OnTimingUpdate(const mojom::PageLoadTiming& timing,
+ // OnTimingUpdate is triggered when an updated PageLoadTiming is available at
+ // the page (page is essentially main frame, with merged values across all
+ // frames for some paint timing values) or subframe level. This method may be
+ // called multiple times over the course of the page load. This method is
+ // currently only intended for use in testing. Most implementers should
+ // implement one of the On* callbacks, such as OnFirstContentfulPaint or
+ // OnDomContentLoadedEventStart. Please email loading-dev@chromium.org if you
+ // intend to override this method.
+ virtual void OnTimingUpdate(bool is_subframe,
+ const mojom::PageLoadTiming& timing,
const PageLoadExtraInfo& extra_info) {}
// OnUserInput is triggered when a new user input is passed in to

Powered by Google App Engine
This is Rietveld 408576698