Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4322)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2903693004: Make PageLoadMetricsWaiter more resilient (Closed)
Patch Set: fix compile Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 985c1544665ae29755dd2704cf26cd437747af83..fe9f281890e4a367400eaeb18e15b0cdaee2880e 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -442,6 +442,9 @@ void MetricsWebContentsObserver::HandleCommittedNavigationForTrackedLoad(
committed_load_ = std::move(tracker);
committed_load_->Commit(navigation_handle);
DCHECK(committed_load_->did_commit());
+
+ for (auto& observer : testing_observers_)
+ observer.OnCommit(committed_load_.get());
}
void MetricsWebContentsObserver::NavigationStopped() {
@@ -624,10 +627,6 @@ void MetricsWebContentsObserver::OnTimingUpdated(
committed_load_->metrics_update_dispatcher()->UpdateMetrics(render_frame_host,
timing, metadata);
-
- const bool is_main_frame = (render_frame_host->GetParent() == nullptr);
- for (auto& observer : testing_observers_)
- observer.OnTimingUpdated(is_main_frame, timing, metadata);
}
void MetricsWebContentsObserver::OnUpdateTimingOverIPC(

Powered by Google App Engine
This is Rietveld 408576698