Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4617)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.cc

Issue 2903693004: Make PageLoadMetricsWaiter more resilient (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_tracker.cc
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.cc b/chrome/browser/page_load_metrics/page_load_tracker.cc
index 125dbf4ca02241d6007c5eba23d65f8e9afb7608..b3c4f643525cce773c7e57ba7ffc3cd6b75a8ec9 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.cc
+++ b/chrome/browser/page_load_metrics/page_load_tracker.cc
@@ -117,7 +117,7 @@ void DispatchObserverTimingCallbacks(
const mojom::PageLoadTiming& new_timing,
const PageLoadExtraInfo& extra_info) {
if (!last_timing.Equals(new_timing))
- observer->OnTimingUpdate(new_timing, extra_info);
+ observer->OnTimingUpdate(false /* is_subframe */, new_timing, extra_info);
if (new_timing.document_timing->dom_content_loaded_event_start &&
!last_timing.document_timing->dom_content_loaded_event_start)
observer->OnDomContentLoadedEventStart(new_timing, extra_info);
@@ -603,6 +603,14 @@ void PageLoadTracker::OnTimingChanged() {
metrics_update_dispatcher_.timing().Clone();
}
+void PageLoadTracker::OnSubFrameTimingChanged(
+ const mojom::PageLoadTiming& timing) {
+ PageLoadExtraInfo extra_info(ComputePageLoadExtraInfo());
+ for (const auto& observer : observers_) {
+ observer->OnTimingUpdate(true /* is_subframe*/, timing, extra_info);
+ }
+}
+
void PageLoadTracker::OnMainFrameMetadataChanged() {
PageLoadExtraInfo extra_info(ComputePageLoadExtraInfo());
for (const auto& observer : observers_) {

Powered by Google App Engine
This is Rietveld 408576698