VR: Update UiSceneManager with screen capturing flag

chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc

Index: chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc b/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
index e88d601f3b3f548d84ec74ea7644e271e390edbb..bac07010c9fc97c79f731ade8b061c2473de4827 100644
--- a/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
@@ -200,4 +200,43 @@ TEST_F(UiSceneManagerTest, UiUpdatesForFullscreenChanges) {
   }
 }
 
+TEST_F(UiSceneManagerTest, UiUpdatesForWebVRChanges) {
+  MakeManager(kNotInCct, kInWebVr);

[cjgrant, 2017/05/26 01:09:26]

This line is initializing a scene manager in WebVR mode, then the line below
transitions into WebVR mode.  Can you please add the two tests as suggested, one
that starts out of webvr with the indicators enabled, then transitions in, and
one that starts in webvr, enables the indicators, and makes sure they don't show
up?  That will verify the two bits of logic needed by the scene manager to
control visibility.

+
+  // Transistion to web vr mode.
+  manager_->SetWebVrMode(true);
+  manager_->SetWebVrSecureOrigin(true);
+
+  // All elements should be hidden.
+  for (const auto& element : scene_->GetUiElements()) {
+    SCOPED_TRACE(element->debug_id());
+    EXPECT_FALSE(element->visible());
+  }
+
+  // Exit webvr mode.
+  std::set<UiElementDebugId> visible_in_browsing = {

[cjgrant, 2017/05/26 00:58:02]

If the text is going to check this set of elements, it should be declared at
module scope and shared.

+      UiElementDebugId::kContentQuad,
+      UiElementDebugId::kBackplane,
+      UiElementDebugId::kCeiling,
+      UiElementDebugId::kFloor,
+      UiElementDebugId::kFloorGrid,
+      UiElementDebugId::kUrlBar,
+      UiElementDebugId::kLoadingIndicator,
+      UiElementDebugId::kAudioCaptureIndicator,
+      UiElementDebugId::kVideoCaptureIndicator,
+      UiElementDebugId::kScreenCaptureIndicator};
+
+  manager_->SetWebVrMode(false);
+  manager_->SetAudioCapturingIndicator(true);

[cjgrant, 2017/05/26 01:09:26]

Miscommunication.  The point of adding this test is to verify that these
indicators do not show in WebVR.  But here, they are no longer being set while
in WebVR.  So therefore, the test is not catching the fact that the logic is
broken.  Or, I am confused.

+  manager_->SetVideoCapturingIndicator(true);
+  manager_->SetScreenCapturingIndicator(true);
+
+  // Everything should return to original state after leaving webvr.
+  for (const auto& element : scene_->GetUiElements()) {
+    SCOPED_TRACE(element->debug_id());
+    bool should_be_visible = visible_in_browsing.find(element->debug_id()) !=
+                             visible_in_browsing.end();
+    EXPECT_EQ(should_be_visible, element->visible());
+  }
+}
 }  // namespace vr_shell