VR: Update UiSceneManager with screen capturing flag

chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc

Index: chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc b/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
index e88d601f3b3f548d84ec74ea7644e271e390edbb..5afb29e1ce8295850ae0d3c55df2f6ce2cbcc652 100644
--- a/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
@@ -200,4 +200,68 @@ TEST_F(UiSceneManagerTest, UiUpdatesForFullscreenChanges) {
   }
 }
 
+TEST_F(UiSceneManagerTest, UiUpdatesForWebVR) {
+  MakeManager(kNotInCct, kInWebVr);
+
+  manager_->SetWebVrSecureOrigin(true);
+  manager_->SetAudioCapturingIndicator(true);
+  manager_->SetVideoCapturingIndicator(true);
+  manager_->SetScreenCapturingIndicator(true);
+
+  // All elements should be hidden.
+  for (const auto& element : scene_->GetUiElements()) {
+    SCOPED_TRACE(element->debug_id());
+    EXPECT_FALSE(element->visible());
+  }
+}
+
+TEST_F(UiSceneManagerTest, UiUpdateTransitionToWebVR) {
+  MakeManager(kNotInCct, kNotInWebVr);
+  manager_->SetAudioCapturingIndicator(true);
+  manager_->SetVideoCapturingIndicator(true);
+  manager_->SetScreenCapturingIndicator(true);
+
+  // Transition to WebVR mode
+  manager_->SetWebVrMode(true);
+  manager_->SetWebVrSecureOrigin(true);
+
+  // All elements should be hidden.
+  for (const auto& element : scene_->GetUiElements()) {
+    SCOPED_TRACE(element->debug_id());
+    EXPECT_FALSE(element->visible());
+  }

[amp, 2017/05/26 17:26:01]

Should we test that transitioning out of WebVR makes everything visible here?

This is kind of already verified by the test below (line 254 and after), but
that test starts with WebVR disabled, enables it and then disables it, where
this test starts with it enabled and then disables it.  There is a possibility
that they could be hitting a different path that way.

OTOH feel free to ignore me if you feel this is too pedantic. :)

[cjgrant, 2017/05/26 17:33:35]

I still feel the same about this as before.  I think testing non-WebVR
visibility is a bigger problem, and should be separate tests.  These tests are
just meant to cover "wherever you were before, when you get into WebVR, nothing
should show".  That a different intent that Amir's test below, which verifies
the indicators across multiple modes.

So my opinion is that this is good as is, and when we have time, we should add a
"regular browsing" test that does heavy testing of the browsing elements, goes
into WebVR and back out, reverifies, etc"..

[amp, 2017/05/26 17:55:30]

That makes sense.  I agree a single large test that goes through all the modes
makes more sense that adding those parts piecemeal into each of the other parts.

So yea this is good as is, we'll revisit those bigger tests in a future change.

+}
+
+TEST_F(UiSceneManagerTest, CaptureIndicatorsVisibility) {
+  MakeManager(kNotInCct, kNotInWebVr);
+  EXPECT_FALSE(IsVisible(kAudioCaptureIndicator));
+  EXPECT_FALSE(IsVisible(kVideoCaptureIndicator));
+  EXPECT_FALSE(IsVisible(kScreenCaptureIndicator));
+
+  manager_->SetAudioCapturingIndicator(true);
+  manager_->SetVideoCapturingIndicator(true);
+  manager_->SetScreenCapturingIndicator(true);
+
+  EXPECT_TRUE(IsVisible(kAudioCaptureIndicator));
+  EXPECT_TRUE(IsVisible(kVideoCaptureIndicator));
+  EXPECT_TRUE(IsVisible(kScreenCaptureIndicator));
+
+  manager_->SetWebVrMode(true);
+  EXPECT_FALSE(IsVisible(kAudioCaptureIndicator));
+  EXPECT_FALSE(IsVisible(kVideoCaptureIndicator));
+  EXPECT_FALSE(IsVisible(kScreenCaptureIndicator));
+
+  manager_->SetWebVrMode(false);
+  EXPECT_TRUE(IsVisible(kAudioCaptureIndicator));
+  EXPECT_TRUE(IsVisible(kVideoCaptureIndicator));
+  EXPECT_TRUE(IsVisible(kScreenCaptureIndicator));
+
+  manager_->SetAudioCapturingIndicator(false);
+  manager_->SetVideoCapturingIndicator(false);
+  manager_->SetScreenCapturingIndicator(false);
+
+  EXPECT_FALSE(IsVisible(kAudioCaptureIndicator));
+  EXPECT_FALSE(IsVisible(kVideoCaptureIndicator));
+  EXPECT_FALSE(IsVisible(kScreenCaptureIndicator));
+}
 }  // namespace vr_shell