Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/preload/onerror-event.html

Issue 2903653005: [preload] Mandatory `as` value and related spec alignments (Closed)
Patch Set: IDL changes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/preload/onerror-event.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/preload/onerror-event.html b/third_party/WebKit/LayoutTests/external/wpt/preload/onerror-event.html
index f503d41d642d66ffe743e638d4b62f1a1d8d35a2..e396628abd758db605ef19e8babde049f8a0a4fb 100644
--- a/third_party/WebKit/LayoutTests/external/wpt/preload/onerror-event.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/preload/onerror-event.html
@@ -15,7 +15,8 @@
var audioFailed = false;
var trackFailed = false;
var gibberishFailed = false;
- var noTypeFailed = false;
+ var fetchFailed = false;
+ var emptyFailed = false;
</script>
<link rel=preload href="non-existent/dummy.js" as=script onerror="scriptFailed = true;">
<link rel=preload href="non-existent/dummy.css" as=style onerror="styleFailed = true;">
@@ -24,8 +25,9 @@
<link rel=preload href="non-existent/test.mp4" as=video onerror="videoFailed = true;">
<link rel=preload href="non-existent/test.oga" as=audio onerror="audioFailed = true;">
<link rel=preload href="non-existent/security/captions.vtt" as=track onerror="trackFailed = true;">
-<link rel=preload href="non-existent/dummy.xml" as=foobarxmlthing onerror="gibberishFailed = true;">
-<link rel=preload href="non-existent/dummy.xml" onerror="noTypeFailed = true;">
+<link rel=preload href="non-existent/dummy.xml?foo" as=foobarxmlthing onerror="gibberishFailed = true;">
+<link rel=preload href="non-existent/dummy.xml?fetch" as=fetch onerror="fetchFailed = true;">
+<link rel=preload href="non-existent/dummy.xml?empty" onerror="emptyFailed = true;">
<script src="resources/dummy.js?pipe=trickle(d5)"></script>
<script>
window.onload = t.step_func(function() {
@@ -37,8 +39,9 @@
assert_true(videoFailed, "video triggered error event");
assert_true(audioFailed, "audio triggered error event");
assert_true(trackFailed, "track triggered error event");
- assert_true(gibberishFailed, "gibberish as value triggered error event");
- assert_true(noTypeFailed, "empty as triggered error event");
+ assert_false(gibberishFailed, "gibberish as value did not trigger error event");
+ assert_true(fetchFailed, "fetch as triggered error event");
+ assert_false(emptyFailed, "empty as triggered error event");
t.done();
});
</script>

Powered by Google App Engine
This is Rietveld 408576698