third_party/WebKit/Source/core/html/HTMLLinkElement.idl - Issue 2903653005: [preload] Mandatory `as` value and related spec alignments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLLinkElement.idl

Issue 2903653005: [preload] Mandatory `as` value and related spec alignments (Closed)

Patch Set: style Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/preload/onerror_event.html ('K') | « third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-preload-use-credentials.html ('k') | third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLLinkElement.idl

diff --git a/third_party/WebKit/Source/core/html/HTMLLinkElement.idl b/third_party/WebKit/Source/core/html/HTMLLinkElement.idl

index e66a9382d7894841ddf41ac74e183ecba4701f1e..d56c6a6683db471a5745055903d2ed09e5eebda1 100644

--- a/third_party/WebKit/Source/core/html/HTMLLinkElement.idl

+++ b/third_party/WebKit/Source/core/html/HTMLLinkElement.idl

@@ -32,7 +32,7 @@ interface HTMLLinkElement : HTMLElement {

[CEReactions, Reflect] attribute DOMString media;

[CEReactions, Reflect] attribute DOMString hreflang;

[CEReactions, Reflect] attribute DOMString type;

- [Reflect] attribute DOMString as;

+ [Reflect, ReflectOnly=("","script","style","image","video", "audio", "track", "font", "fetch"), ReflectMissing="", ReflectInvalid=""] attribute DOMString as;

Charlie Harrison 2017/05/28 22:22:43 Not an expert on idl, does this enforce case sensi

Yoav Weiss 2017/05/31 05:00:40 It enforces case-sensiticity on the output, but no

[CEReactions, Reflect, ReflectOnly=("","no-referrer","origin","no-referrer-when-downgrade","origin-when-cross-origin","unsafe-url"), ReflectMissing="", ReflectInvalid=""] attribute DOMString referrerPolicy;

[CEReactions, PutForwards=value] readonly attribute DOMTokenList sizes;