Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h

Issue 2903643002: PaymentHandler: Implement PaymentRequestEvent constructor. (Closed)
Patch Set: constructor Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
index 42be7d1596a5a20e22e4bdfaae8570250abf82ae..7d19b60e59253fe30dc0bba476cf1953da5acf4a 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
@@ -24,6 +24,8 @@ class MODULES_EXPORT PaymentRequestEvent final : public ExtendableEvent {
public:
static PaymentRequestEvent* Create(const AtomicString& type,
+ const PaymentRequestEventInit&);
+ static PaymentRequestEvent* Create(const AtomicString& type,
const PaymentRequestEventInit&,
RespondWithObserver*,
WaitUntilObserver*);
@@ -45,6 +47,7 @@ class MODULES_EXPORT PaymentRequestEvent final : public ExtendableEvent {
DECLARE_VIRTUAL_TRACE();
private:
+ PaymentRequestEvent(const AtomicString& type, const PaymentRequestEventInit&);
please use gerrit instead 2017/06/05 15:38:55 Would you mind having a single constructor that bo
zino 2017/06/06 15:03:12 Done.
PaymentRequestEvent(const AtomicString& type,
const PaymentRequestEventInit&,
RespondWithObserver*,

Powered by Google App Engine
This is Rietveld 408576698