content/browser/frame_host/interstitial_page_impl.h - Issue 2903593003: Fix crash bug http://crbug.com/725594

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_impl.h

Issue 2903593003: Fix crash bug http://crbug.com/725594 (Closed)

Patch Set: Use std::unique_ptr to control the lifetime of FrameTree obviously Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/interstitial_page_impl.h

diff --git a/content/browser/frame_host/interstitial_page_impl.h b/content/browser/frame_host/interstitial_page_impl.h

index 26beb24780b5c0264c90490a0164ac1378c4219b..71c33a0ee760bcfb0d2ed60c30cefd57bd3f4c38 100644

--- a/content/browser/frame_host/interstitial_page_impl.h

+++ b/content/browser/frame_host/interstitial_page_impl.h

@@ -265,7 +265,7 @@ class CONTENT_EXPORT InterstitialPageImpl

RenderViewHostImpl* render_view_host_;

// The frame tree structure of the current page.

- FrameTree frame_tree_;

+ std::unique_ptr<FrameTree> frame_tree_;

// The IDs for the Render[View|Process]Host hidden by this interstitial.

int original_child_id_;