src/builtins/x64/builtins-x64.cc - Issue 2903533002: Revert of [es2015] Precompute the descriptive string for symbols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/x64/builtins-x64.cc

Issue 2903533002: Revert of [es2015] Precompute the descriptive string for symbols. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/x64/builtins-x64.cc

diff --git a/src/builtins/x64/builtins-x64.cc b/src/builtins/x64/builtins-x64.cc

index 6b5ecdf792bbc5d05111c800abe8cb63aa14bfc2..d4fb131afc79142508d97533d7f82ee3096de2f3 100644

--- a/src/builtins/x64/builtins-x64.cc

+++ b/src/builtins/x64/builtins-x64.cc

@@ -1987,8 +1987,14 @@

// 3b. Convert symbol in rax to a string.

__ bind(&symbol_descriptive_string);

- __ movp(rax, FieldOperand(rax, Symbol::kDescriptiveStringOffset));

- // Fall through.

+ {

+ __ PopReturnAddressTo(rcx);

+ __ SmiToInteger32(r8, r8);

+ __ leap(rsp, Operand(rsp, r8, times_pointer_size, kPointerSize));

+ __ Push(rax);

+ __ PushReturnAddressFrom(rcx);

+ __ TailCallRuntime(Runtime::kSymbolDescriptiveString);

+ }

__ bind(&drop_frame_and_ret);

{

« no previous file with comments | « src/builtins/mips64/builtins-mips64.cc ('k') | src/factory.h » ('j') | no next file with comments »