Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: src/objects-inl.h

Issue 2903533002: Revert of [es2015] Precompute the descriptive string for symbols. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-debug.cc ('k') | src/runtime/runtime-symbol.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 3467 matching lines...) Expand 10 before | Expand all | Expand 10 after
3478 if ((one->IsInternalizedString() && two->IsInternalizedString()) || 3478 if ((one->IsInternalizedString() && two->IsInternalizedString()) ||
3479 one->IsSymbol() || two->IsSymbol()) { 3479 one->IsSymbol() || two->IsSymbol()) {
3480 return false; 3480 return false;
3481 } 3481 }
3482 return String::SlowEquals(Handle<String>::cast(one), 3482 return String::SlowEquals(Handle<String>::cast(one),
3483 Handle<String>::cast(two)); 3483 Handle<String>::cast(two));
3484 } 3484 }
3485 3485
3486 3486
3487 ACCESSORS(Symbol, name, Object, kNameOffset) 3487 ACCESSORS(Symbol, name, Object, kNameOffset)
3488 ACCESSORS(Symbol, descriptive_string, String, kDescriptiveStringOffset)
3489 SMI_ACCESSORS(Symbol, flags, kFlagsOffset) 3488 SMI_ACCESSORS(Symbol, flags, kFlagsOffset)
3490 BOOL_ACCESSORS(Symbol, flags, is_private, kPrivateBit) 3489 BOOL_ACCESSORS(Symbol, flags, is_private, kPrivateBit)
3491 BOOL_ACCESSORS(Symbol, flags, is_well_known_symbol, kWellKnownSymbolBit) 3490 BOOL_ACCESSORS(Symbol, flags, is_well_known_symbol, kWellKnownSymbolBit)
3492 BOOL_ACCESSORS(Symbol, flags, is_public, kPublicBit) 3491 BOOL_ACCESSORS(Symbol, flags, is_public, kPublicBit)
3493 3492
3494 bool String::Equals(String* other) { 3493 bool String::Equals(String* other) {
3495 if (other == this) return true; 3494 if (other == this) return true;
3496 if (this->IsInternalizedString() && other->IsInternalizedString()) { 3495 if (this->IsInternalizedString() && other->IsInternalizedString()) {
3497 return false; 3496 return false;
3498 } 3497 }
(...skipping 4769 matching lines...) Expand 10 before | Expand all | Expand 10 after
8268 #undef WRITE_BYTE_FIELD 8267 #undef WRITE_BYTE_FIELD
8269 #undef NOBARRIER_READ_BYTE_FIELD 8268 #undef NOBARRIER_READ_BYTE_FIELD
8270 #undef NOBARRIER_WRITE_BYTE_FIELD 8269 #undef NOBARRIER_WRITE_BYTE_FIELD
8271 8270
8272 } // namespace internal 8271 } // namespace internal
8273 } // namespace v8 8272 } // namespace v8
8274 8273
8275 #include "src/objects/object-macros-undef.h" 8274 #include "src/objects/object-macros-undef.h"
8276 8275
8277 #endif // V8_OBJECTS_INL_H_ 8276 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects-debug.cc ('k') | src/runtime/runtime-symbol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698