Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/builtins/ia32/builtins-ia32.cc

Issue 2903533002: Revert of [es2015] Precompute the descriptive string for symbols. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins-symbol-gen.cc ('k') | src/builtins/mips/builtins-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 1991 matching lines...) Expand 10 before | Expand all | Expand 10 after
2002 __ SmiTag(ebx); 2002 __ SmiTag(ebx);
2003 __ EnterBuiltinFrame(esi, edi, ebx); 2003 __ EnterBuiltinFrame(esi, edi, ebx);
2004 __ Call(masm->isolate()->builtins()->ToString(), RelocInfo::CODE_TARGET); 2004 __ Call(masm->isolate()->builtins()->ToString(), RelocInfo::CODE_TARGET);
2005 __ LeaveBuiltinFrame(esi, edi, ebx); 2005 __ LeaveBuiltinFrame(esi, edi, ebx);
2006 __ SmiUntag(ebx); 2006 __ SmiUntag(ebx);
2007 } 2007 }
2008 __ jmp(&drop_frame_and_ret, Label::kNear); 2008 __ jmp(&drop_frame_and_ret, Label::kNear);
2009 2009
2010 // 3b. Convert symbol in eax to a string. 2010 // 3b. Convert symbol in eax to a string.
2011 __ bind(&symbol_descriptive_string); 2011 __ bind(&symbol_descriptive_string);
2012 __ mov(eax, FieldOperand(eax, Symbol::kDescriptiveStringOffset)); 2012 {
2013 // Fall through. 2013 __ PopReturnAddressTo(ecx);
2014 __ lea(esp, Operand(esp, ebx, times_pointer_size, kPointerSize));
2015 __ Push(eax);
2016 __ PushReturnAddressFrom(ecx);
2017 __ TailCallRuntime(Runtime::kSymbolDescriptiveString);
2018 }
2014 2019
2015 __ bind(&drop_frame_and_ret); 2020 __ bind(&drop_frame_and_ret);
2016 { 2021 {
2017 // Drop all arguments including the receiver. 2022 // Drop all arguments including the receiver.
2018 __ PopReturnAddressTo(ecx); 2023 __ PopReturnAddressTo(ecx);
2019 __ lea(esp, Operand(esp, ebx, times_pointer_size, kPointerSize)); 2024 __ lea(esp, Operand(esp, ebx, times_pointer_size, kPointerSize));
2020 __ PushReturnAddressFrom(ecx); 2025 __ PushReturnAddressFrom(ecx);
2021 __ Ret(); 2026 __ Ret();
2022 } 2027 }
2023 } 2028 }
(...skipping 1296 matching lines...) Expand 10 before | Expand all | Expand 10 after
3320 } 3325 }
3321 // Now jump to the instructions of the returned code object. 3326 // Now jump to the instructions of the returned code object.
3322 __ jmp(edi); 3327 __ jmp(edi);
3323 } 3328 }
3324 3329
3325 #undef __ 3330 #undef __
3326 } // namespace internal 3331 } // namespace internal
3327 } // namespace v8 3332 } // namespace v8
3328 3333
3329 #endif // V8_TARGET_ARCH_IA32 3334 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/builtins/builtins-symbol-gen.cc ('k') | src/builtins/mips/builtins-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698