Revert of [es2015] Precompute the descriptive string for symbols.

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 8033 matching lines @@
                           mode == ArrayBufferCreationMode::kExternalized, data,
                           byte_length, i::SharedFlag::kShared);
   return Utils::ToLocalShared(obj);
 }
 
 
 Local<Symbol> v8::Symbol::New(Isolate* isolate, Local<String> name) {
   i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
   LOG_API(i_isolate, Symbol, New);
   ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate);
-  i::Handle<i::Symbol> result;
-  i::Handle<i::Object> i_name =
-      name.IsEmpty()
-          ? i::Handle<i::Object>::cast(i_isolate->factory()->undefined_value())
-          : i::Handle<i::Object>::cast(Utils::OpenHandle(*name));
-  if (!i_isolate->factory()->NewSymbol(i_name).ToHandle(&result)) {
-    i::FatalProcessOutOfMemory("v8::Symbol::New");
-  }
+  i::Handle<i::Symbol> result = i_isolate->factory()->NewSymbol();
+  if (!name.IsEmpty()) result->set_name(*Utils::OpenHandle(*name));
   return Utils::ToLocal(result);
 }
 
 
 Local<Symbol> v8::Symbol::For(Isolate* isolate, Local<String> name) {
   i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
   i::Handle<i::String> i_name = Utils::OpenHandle(*name);
   return Utils::ToLocal(i_isolate->SymbolFor(
       i::Heap::kPublicSymbolTableRootIndex, i_name, false));
 }
@@ skipping 26 matching lines @@
 
 WELL_KNOWN_SYMBOLS(SYMBOL_GETTER)
 
 #undef SYMBOL_GETTER
 #undef WELL_KNOWN_SYMBOLS
 
 Local<Private> v8::Private::New(Isolate* isolate, Local<String> name) {
   i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
   LOG_API(i_isolate, Private, New);
   ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate);
-  i::Handle<i::Symbol> result;
-  i::Handle<i::Object> i_name =
-      name.IsEmpty()
-          ? i::Handle<i::Object>::cast(i_isolate->factory()->undefined_value())
-          : i::Handle<i::Object>::cast(Utils::OpenHandle(*name));
-  if (!i_isolate->factory()->NewPrivateSymbol(i_name).ToHandle(&result)) {
-    i::FatalProcessOutOfMemory("v8::Private::New");
-  }
-  return v8::Local<Private>(
-      reinterpret_cast<Private*>(*Utils::ToLocal(result)));
+  i::Handle<i::Symbol> symbol = i_isolate->factory()->NewPrivateSymbol();
+  if (!name.IsEmpty()) symbol->set_name(*Utils::OpenHandle(*name));
+  Local<Symbol> result = Utils::ToLocal(symbol);
+  return v8::Local<Private>(reinterpret_cast<Private*>(*result));
 }
 
 
 Local<Private> v8::Private::ForApi(Isolate* isolate, Local<String> name) {
   i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
   i::Handle<i::String> i_name = Utils::OpenHandle(*name);
   Local<Symbol> result = Utils::ToLocal(i_isolate->SymbolFor(
       i::Heap::kApiPrivateSymbolTableRootIndex, i_name, true));
   return v8::Local<Private>(reinterpret_cast<Private*>(*result));
 }
@@ skipping 2396 matching lines @@
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 }  // namespace internal
 }  // namespace v8