Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: Source/core/svg/SVGDocumentExtensions.cpp

Issue 290353002: SVG: Moving animating <svg> to other iframe should not crash. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: RELEASE_ASSERT Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/resources/svg-with-animate.svg ('k') | Source/core/svg/animation/SMILTimeContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGDocumentExtensions.cpp
diff --git a/Source/core/svg/SVGDocumentExtensions.cpp b/Source/core/svg/SVGDocumentExtensions.cpp
index b8665f61731e5afa1273dd05fe3b8fd7a5e7a7f5..bf28cc21f5f24a112c4381a7a47891f7a2868b6b 100644
--- a/Source/core/svg/SVGDocumentExtensions.cpp
+++ b/Source/core/svg/SVGDocumentExtensions.cpp
@@ -111,8 +111,11 @@ void SVGDocumentExtensions::startAnimations()
WillBeHeapVector<RefPtrWillBeMember<SVGSVGElement> > timeContainers;
timeContainers.appendRange(m_timeContainers.begin(), m_timeContainers.end());
WillBeHeapVector<RefPtrWillBeMember<SVGSVGElement> >::iterator end = timeContainers.end();
- for (WillBeHeapVector<RefPtrWillBeMember<SVGSVGElement> >::iterator itr = timeContainers.begin(); itr != end; ++itr)
- (*itr)->timeContainer()->begin();
+ for (WillBeHeapVector<RefPtrWillBeMember<SVGSVGElement> >::iterator itr = timeContainers.begin(); itr != end; ++itr) {
+ SMILTimeContainer* timeContainer = (*itr)->timeContainer();
+ if (!timeContainer->isStarted())
+ timeContainer->begin();
+ }
}
void SVGDocumentExtensions::pauseAnimations()
« no previous file with comments | « LayoutTests/svg/dom/resources/svg-with-animate.svg ('k') | Source/core/svg/animation/SMILTimeContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698