third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp - Issue 2903493002: NetInfo network quality extension: Add callbacks and Layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2903493002: NetInfo network quality extension: Add callbacks and Layout tests (Closed)

Patch Set: haraken comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

index dc0f1bcb799dcf223df370b0c09ae2217958734f..01b2b58b04511a789bd052b81bf3983f9cf31cbf 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

@@ -1389,7 +1389,7 @@ Response InspectorNetworkAgent::emulateNetworkConditions(

// TODO(dgozman): networkStateNotifier is per-process. It would be nice to

// have per-frame override instead.

if (offline || latency || download_throughput || upload_throughput)

- GetNetworkStateNotifier().SetOverride(

+ GetNetworkStateNotifier().SetNetworkConnectionInfoOverride(

!offline, type, download_throughput / (1024 * 1024 / 8));

else

GetNetworkStateNotifier().ClearOverride();