third_party/WebKit/Source/core/testing/NetInfo.idl - Issue 2903493002: NetInfo network quality extension: Add callbacks and Layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/testing/NetInfo.idl

Issue 2903493002: NetInfo network quality extension: Add callbacks and Layout tests (Closed)

Patch Set: Rebased, Use enum instead of string Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 enum EffectiveConnectionType {
	haraken 2017/06/02 04:03:56 Can we move this enum to Internals.idl? We don't Can we move this enum to Internals.idl? We don't need to define the NetInfo interface. tbansal1 2017/06/02 04:42:11 Done. Show quoted text On 2017/06/02 04:03:56, haraken wrote: > > Can we move this enum to Internals.idl? > > We don't need to define the NetInfo interface. Done.
	6 "slow-2g",

	7 "2g",

	8 "3g",

	9 "4g"

	10 };

	11

	12 interface NetInfo {

	13 };

OLD	NEW