third_party/WebKit/LayoutTests/netinfo/network-quality.html - Issue 2903493002: NetInfo network quality extension: Add callbacks and Layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/netinfo/network-quality.html

Issue 2903493002: NetInfo network quality extension: Add callbacks and Layout tests (Closed)

Patch Set: ps Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/netinfo/estimate-web-worker-expected.txt ('k') | third_party/WebKit/LayoutTests/netinfo/network-quality-expected.txt » ('j') | third_party/WebKit/Source/core/testing/Internals.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <head>

	3 <script src="../resources/js-test.js"></script>

	4 <script src="resources/netinfo_common.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 description('Tests that all rtt and downlink is exposed correctly.');

	9

	10 if (!window.internals)

	11 log("This test requires window.internals");

	12

	13 var values = [

	14 ["slow-2g", 25.0, 2.0, "slow-2g", 25.0, 2.0],

	15 ["slow-2g", 40.0, 2.0, "slow-2g", 50.0, 2.0],

	16 ["slow-2g", 40.0, 0.0, "slow-2g", 50.0, 0.0],

	17 ["slow-2g", 40.0, 0.125, "slow-2g", 50.0, 0.125],

	18 ["slow-2g", 40.0, 0.103, "slow-2g", 50.0, 0.1],

	19 ["slow-2g", 40.0, 0.123, "slow-2g", 50.0, 0.125],

	20 ["2g", 40.0, 0.123, "2g", 50.0, 0.125],

	21 ["3g", 40.0, 0.123, "3g", 50.0, 0.125],

	22 ["3g", 10.0, 0.123, "3g", 0.0, 0.125],

	23 ];

	24

	25 var count = 0;

	26 connection.addEventListener('change', function(e) {

	27 shouldBe('connection.effectiveType', 'values[count][3]');

	28 shouldBe('connection.rtt', 'values[count][4]');

	29 shouldBe('connection.downlink', 'values[count][5]');

	30

	31 if (++count === values.length)

	32 finishJSTest();

	33 });

	34

	35 for(var i = 0; i < values.length; i++)

	36 internals.setNetworkQualityInfoOverride(values[i][0], values[i][1], values[i][ 2]);
	foolip 2017/05/31 14:31:16 I haven't looked at the whole CL, but at least thi I haven't looked at the whole CL, but at least this test seems to be for things that are required by the spec but impossible to test without internals. (As opposed to behavior that's deliberately left undefined but where we want to test our choices.) Can you file an issue blocking issue 707649 for what it would take to share a test like this across implementations? If this is the only test then it's probably not worth the effort, but if web developers could also make use of WebDriver commands to test their web apps, maybe it is.
	37

	38 </script>

	39 </body>

	40 </html>

OLD	NEW