components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc - Issue 2903453003: DataReductionProxy proto change to use exp=force_lite_page directive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc

Issue 2903453003: DataReductionProxy proto change to use exp=force_lite_page directive (Closed)

Patch Set: Adjusted directive terminology to experiment terminology Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc

index 82d2d83f2e37b262787ccf4a5c79769fb73cb670..fa8df6aff62f4d5df267f37aa63151dc1b83987a 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc

@@ -355,14 +355,14 @@ TEST_F(DataReductionProxyRequestOptionsTest, TestExperimentPrecedence) {

CreateRequestOptions(kVersion);

VerifyExpectedHeader(expected_header, kPageIdValue);

- // "ignore_preview_blacklist" has the next lowest priority.

+ // "force_lite_page" has the next lowest priority.

base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(

switches::kDataReductionProxyLoFi,

switches::kDataReductionProxyLoFiValueAlwaysOn);

base::CommandLine::ForCurrentProcess()->AppendSwitch(

switches::kEnableDataReductionProxyLitePage);

expected_experiments.clear();

- expected_experiments.push_back(chrome_proxy_lite_page_ignore_blacklist());

+ expected_experiments.push_back(chrome_proxy_force_lite_page_experiment());

SetHeaderExpectations(kExpectedSession, kExpectedCredentials, std::string(),

kClientStr, kExpectedBuild, kExpectedPatch, kPageId,

expected_experiments, &expected_header);