Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: chrome/browser/metrics/metrics_service_unittest.cc

Issue 290343005: Pass MetricsServiceClient into MetricsService, and create a simple stubbed TestMetricsServiceClient… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service_unittest.cc
diff --git a/chrome/browser/metrics/metrics_service_unittest.cc b/chrome/browser/metrics/metrics_service_unittest.cc
index c3bef76eed3854798e608008c47fe3b8c6cdf02d..b4af6e5ab685256f6f7b58a493abd52fd36c4833 100644
--- a/chrome/browser/metrics/metrics_service_unittest.cc
+++ b/chrome/browser/metrics/metrics_service_unittest.cc
@@ -14,6 +14,7 @@
#include "chrome/common/pref_names.h"
#include "chrome/test/base/scoped_testing_local_state.h"
#include "chrome/test/base/testing_browser_process.h"
+#include "components/metrics/test_metrics_service_client.h"
#include "components/variations/metrics_util.h"
#include "content/public/common/process_type.h"
#include "content/public/common/webplugininfo.h"
@@ -31,8 +32,9 @@ using metrics::MetricsLogManager;
class TestMetricsService : public MetricsService {
public:
- explicit TestMetricsService(metrics::MetricsStateManager* state_manager)
- : MetricsService(state_manager) {
+ TestMetricsService(metrics::MetricsStateManager* state_manager,
+ metrics::MetricsServiceClient* client)
+ : MetricsService(state_manager, client) {
}
virtual ~TestMetricsService() {}
@@ -177,7 +179,8 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAfterCleanShutDown) {
EnableMetricsReporting();
GetLocalState()->SetBoolean(prefs::kStabilityExitedCleanly, true);
- TestMetricsService service(GetMetricsStateManager());
+ metrics::TestMetricsServiceClient client;
+ TestMetricsService service(GetMetricsStateManager(), &client);
service.InitializeMetricsRecordingState();
// No initial stability log should be generated.
EXPECT_FALSE(service.log_manager()->has_unsent_logs());
@@ -206,7 +209,8 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAfterCrash) {
GetLocalState()->SetBoolean(prefs::kStabilityExitedCleanly, false);
- TestMetricsService service(GetMetricsStateManager());
+ metrics::TestMetricsServiceClient client;
+ TestMetricsService service(GetMetricsStateManager(), &client);
service.InitializeMetricsRecordingState();
// The initial stability log should be generated and persisted in unsent logs.
@@ -234,7 +238,8 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAfterCrash) {
}
TEST_F(MetricsServiceTest, RegisterSyntheticTrial) {
- MetricsService service(GetMetricsStateManager());
+ metrics::TestMetricsServiceClient client;
+ MetricsService service(GetMetricsStateManager(), &client);
// Add two synthetic trials and confirm that they show up in the list.
SyntheticTrialGroup trial1(metrics::HashName("TestTrial1"),
@@ -332,7 +337,8 @@ TEST_F(MetricsServiceTest, CrashReportingEnabled) {
}
TEST_F(MetricsServiceTest, MetricsServiceObserver) {
- MetricsService service(GetMetricsStateManager());
+ metrics::TestMetricsServiceClient client;
+ MetricsService service(GetMetricsStateManager(), &client);
TestMetricsServiceObserver observer1;
TestMetricsServiceObserver observer2;

Powered by Google App Engine
This is Rietveld 408576698