Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 290343003: Fix browser test to work with dynamic CLD (Closed)

Created:
6 years, 7 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 7 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@cld_browsertest
Visibility:
Public.

Description

Fix browser test to work with dynamic CLD BUG=367239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271846

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add call to Init() to workaround gtest macro issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/translate/translate_manager_browsertest.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Andrew Hayden (chromium.org)
Dear owner: NB: This change depends upon https://codereview.chromium.org/285293004/. We are making it possible for the ...
6 years, 7 months ago (2014-05-19 12:56:47 UTC) #1
Takashi Toyoshima
lgtm https://codereview.chromium.org/290343003/diff/1/chrome/browser/translate/translate_manager_browsertest.cc File chrome/browser/translate/translate_manager_browsertest.cc (right): https://codereview.chromium.org/290343003/diff/1/chrome/browser/translate/translate_manager_browsertest.cc#newcode30 chrome/browser/translate/translate_manager_browsertest.cc:30: test::ScopedCLDDynamicDataHarness dynamic_data_scope; Or you may want to have ...
6 years, 7 months ago (2014-05-19 14:32:47 UTC) #2
Andrew Hayden (chromium.org)
Takashi, any issue with patchset 2?
6 years, 7 months ago (2014-05-19 17:41:09 UTC) #3
Takashi Toyoshima
still lgtm
6 years, 7 months ago (2014-05-19 18:13:26 UTC) #4
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 7 months ago (2014-05-20 18:43:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/290343003/20001
6 years, 7 months ago (2014-05-20 18:44:35 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 03:37:10 UTC) #7
Message was sent while issue was closed.
Change committed as 271846

Powered by Google App Engine
This is Rietveld 408576698