third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js - Issue 2903413002: Restructure type tracking in StyleValues to work better with new numeric types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js

Issue 2903413002: Restructure type tracking in StyleValues to work better with new numeric types (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/left-expected.txt ('k') | third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/right-expected.txt » ('j') | third_party/WebKit/Source/build/scripts/make_css_property_metadata.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js

diff --git a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js b/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js

index a6e97ab8d8ea5e2ca7ea438042f476317f7db26c..39e673a8f9e321e9245e50929dc7e5c6069dce78 100644

--- a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js

+++ b/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js

@@ -103,7 +103,8 @@ function runSetterTests(

// Negative tests

for (let invalidObject of invalidObjects) {

let name = invalidObject instanceof CSSStyleValue ?

- invalidObject.constructor.name : invalidObject;

+ invalidObject.constructor.name + ' "' + invalidObject.cssText + '"' :

+ invalidObject;

test(function() {

assert_throws(new TypeError(), function() {

element.styleMap.set(propertyName, invalidObject);