third_party/WebKit/Source/build/scripts/make_css_property_metadata.py - Issue 2903413002: Restructure type tracking in StyleValues to work better with new numeric types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_css_property_metadata.py

Issue 2903413002: Restructure type tracking in StyleValues to work better with new numeric types (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-perspective-expected.txt ('k') | third_party/WebKit/Source/build/scripts/make_cssom_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_css_property_metadata.py

diff --git a/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py b/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py

index 1fa4eba59cf01d6d187b049973cb69b7dc41c44c..500c85a3345567c34565f2fd34ad48aa100aa104 100755

--- a/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py

+++ b/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py

@@ -18,7 +18,13 @@ class CSSPropertyMetadataWriter(css_properties.CSSProperties):

def __init__(self, json5_file_path):

super(CSSPropertyMetadataWriter, self).__init__(json5_file_path)

- self._outputs = {'CSSPropertyMetadata.cpp': self.generate_css_property_metadata_cpp}

+ self._outputs = {

+ 'CSSPropertyMetadata.cpp':

+ self.generate_css_property_metadata_cpp

+ }

+ for property_value in self._properties.values():

+ property_value['supports_percentage'] = (

+ 'Percent' in property_value['typedom_types'])

@template_expander.use_jinja('CSSPropertyMetadata.cpp.tmpl', filters=filters)

def generate_css_property_metadata_cpp(self):