Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: ash/login/lock_screen_controller.h

Issue 2903353003: Adding mojo calls for easy unlock service (Closed)
Patch Set: incoporate comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/login/lock_screen_controller.cc » ('j') | ash/public/interfaces/lock_screen.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/login/lock_screen_controller.h
diff --git a/ash/login/lock_screen_controller.h b/ash/login/lock_screen_controller.h
index 50bc9e526c9783507f1f3c0f0f778d70c6ebd2bb..da616ba8a6b690a165473312710789abfa372620 100644
--- a/ash/login/lock_screen_controller.h
+++ b/ash/login/lock_screen_controller.h
@@ -33,6 +33,16 @@ class ASH_EXPORT LockScreenController
const std::string& help_link_text,
int32_t help_topic_id) override;
void ClearErrors() override;
+ void LoadUsers(std::unique_ptr<base::ListValue> users,
xiyuan 2017/05/31 17:51:18 nit: Follow the declaration order in mojom
xiaoyinh(OOO Sep 11-29) 2017/06/02 23:42:28 Done.
+ bool show_guest) override;
+
xiyuan 2017/05/31 17:51:18 nit: no empty line to break the overridden interfa
xiaoyinh(OOO Sep 11-29) 2017/06/02 23:42:28 Done.
+ void ShowUserPodCustomIcon(
+ const AccountId& account_id,
+ std::unique_ptr<base::DictionaryValue> icon) override;
+ void HideUserPodCustomIcon(const AccountId& account_id) override;
+ void SetAuthType(const AccountId& account_id,
+ int auth_type,
+ const std::string& initial_value) override;
// Wrappers around the mojom::SystemTrayClient interface.
xiyuan 2017/05/31 17:51:18 nit: This comment looks wrong.
xiaoyinh(OOO Sep 11-29) 2017/06/02 23:42:28 Oops, changed.
// Hash the password and send AuthenticateUser request to LockScreenClient.
@@ -42,6 +52,9 @@ class ASH_EXPORT LockScreenController
void AuthenticateUser(const AccountId& account_id,
const std::string& password,
bool authenticated_by_pin);
+ void AttemptUnlock(const AccountId& account_id);
+ void HardlockPod(const AccountId& account_id);
+ void RecordClickOnLockIcon(const AccountId& account_id);
private:
void DoAuthenticateUser(const AccountId& account_id,
« no previous file with comments | « no previous file | ash/login/lock_screen_controller.cc » ('j') | ash/public/interfaces/lock_screen.mojom » ('J')

Powered by Google App Engine
This is Rietveld 408576698