Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: ui/ozone/platform/drm/host/drm_cursor.h

Issue 2903353002: Make ozone/drm/mojo more immune to startup races (Closed)
Patch Set: simpler patch Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/ozone/platform/drm/cursor_proxy_mojo.cc ('k') | ui/ozone/platform/drm/host/drm_cursor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ozone/platform/drm/host/drm_cursor.h
diff --git a/ui/ozone/platform/drm/host/drm_cursor.h b/ui/ozone/platform/drm/host/drm_cursor.h
index 092f8ce10f39d723d853397ea6a0f5aa6972d244..a31f27f2422daec55d9095a1baecad117a73b11b 100644
--- a/ui/ozone/platform/drm/host/drm_cursor.h
+++ b/ui/ozone/platform/drm/host/drm_cursor.h
@@ -34,7 +34,7 @@ class DrmCursorProxy {
virtual void Move(gfx::AcceleratedWidget window, const gfx::Point& point) = 0;
// Initialize EvdevThread-specific state.
- virtual void InitializeOnEvdev() = 0;
+ virtual void InitializeOnEvdevIfNecessary() = 0;
};
// DrmCursor manages all cursor state and semantics.
@@ -43,9 +43,10 @@ class DrmCursor : public CursorDelegateEvdev {
explicit DrmCursor(DrmWindowHostManager* window_manager);
~DrmCursor() override;
- // Sets or resets the DrmProxy |proxy|. If |proxy| is set, the DrmCursor uses
- // it to communicate to the GPU process or thread.
- void SetDrmCursorProxy(DrmCursorProxy* proxy);
+ // Sets or the DrmProxy |proxy|. If |proxy| is set, the DrmCursor uses
+ // it to communicate to the GPU process or thread. Returns the previous
+ // value.
+ void SetDrmCursorProxy(std::unique_ptr<DrmCursorProxy> proxy);
void ResetDrmCursorProxy();
// Change the cursor over the specifed window.
« no previous file with comments | « ui/ozone/platform/drm/cursor_proxy_mojo.cc ('k') | ui/ozone/platform/drm/host/drm_cursor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698