Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 290333012: [Win] Draw the circular avatar programmatically rather than with a frame. (Closed)

Created:
6 years, 7 months ago by noms (inactive)
Modified:
6 years, 7 months ago
Reviewers:
danakj, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[Win] Draw the circular avatar programmatically rather than with a frame. On Linux, the OS theme can change, which affects the default background colour of the avatar bubble. This means that using a frame overlay to display the profile avatar as an image is not actually feasible. This also adds a small change to the ClipPath function of gfx::Canvas, to allow controlling the anti-aliasing option. BUG=372721 TEST=Start Chrome with --new-profile-management. Click on the avatar button. The avatar should still be displayed as a circle. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272854

Patch Set 1 : #

Patch Set 2 : add missing virtual keyword #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 4 chunks +24 lines, -8 lines 0 comments Download
M ui/app_list/views/app_list_background.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/canvas.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/controls/progress_bar.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
noms (inactive)
Hi, We were displaying the profile avatar as a circle in the new avatar menu ...
6 years, 7 months ago (2014-05-22 17:11:08 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-22 19:33:20 UTC) #2
noms (inactive)
Dana: Ping! :)
6 years, 7 months ago (2014-05-23 20:55:46 UTC) #3
danakj
sky is a better owner for ui/gfx/canvas and has already given his approval. I'll remove ...
6 years, 7 months ago (2014-05-24 01:02:49 UTC) #4
noms (inactive)
Understood, thanks! On 2014/05/24 01:02:49, danakj (OOO_back_june_6) wrote: > sky is a better owner for ...
6 years, 7 months ago (2014-05-25 14:28:49 UTC) #5
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 7 months ago (2014-05-25 14:28:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/290333012/60001
6 years, 7 months ago (2014-05-25 14:29:06 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 16:20:24 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 16:24:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77499)
6 years, 7 months ago (2014-05-25 16:24:31 UTC) #10
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 7 months ago (2014-05-26 15:48:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/290333012/60001
6 years, 7 months ago (2014-05-26 15:50:46 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 16:43:53 UTC) #13
Message was sent while issue was closed.
Change committed as 272854

Powered by Google App Engine
This is Rietveld 408576698