Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 290333008: Oilpan: add [WillBeGarbageCollected] for Element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + remove WebNode FIXME Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/CustomElementWrapper.cpp ('k') | Source/core/dom/ContainerNode.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 if (index.IsEmpty()) { 64 if (index.IsEmpty()) {
65 TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info. GetIsolate())); 65 TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info. GetIsolate()));
66 v8::Handle<v8::Value> result = getNamedItems(collection, name, info); 66 v8::Handle<v8::Value> result = getNamedItems(collection, name, info);
67 67
68 if (result.IsEmpty()) 68 if (result.IsEmpty())
69 return v8::Undefined(info.GetIsolate()); 69 return v8::Undefined(info.GetIsolate());
70 70
71 return result; 71 return result;
72 } 72 }
73 73
74 RefPtr<Element> result = collection->item(index->Uint32Value()); 74 RefPtrWillBeRawPtr<Element> result = collection->item(index->Uint32Value());
75 return toV8(result.release(), info.Holder(), info.GetIsolate()); 75 return toV8(result.release(), info.Holder(), info.GetIsolate());
76 } 76 }
77 77
78 void V8HTMLAllCollection::itemMethodCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info) 78 void V8HTMLAllCollection::itemMethodCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info)
79 { 79 {
80 HTMLAllCollection* impl = V8HTMLAllCollection::toNative(info.Holder()); 80 HTMLAllCollection* impl = V8HTMLAllCollection::toNative(info.Holder());
81 v8SetReturnValue(info, getItem(impl, info[0], info)); 81 v8SetReturnValue(info, getItem(impl, info[0], info));
82 } 82 }
83 83
84 void V8HTMLAllCollection::legacyCallCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info) 84 void V8HTMLAllCollection::legacyCallCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info)
(...skipping 17 matching lines...) Expand all
102 if (index.IsEmpty()) 102 if (index.IsEmpty())
103 return; 103 return;
104 104
105 if (Node* node = impl->namedItemWithIndex(name, index->Uint32Value())) { 105 if (Node* node = impl->namedItemWithIndex(name, index->Uint32Value())) {
106 v8SetReturnValueFast(info, node, impl); 106 v8SetReturnValueFast(info, node, impl);
107 return; 107 return;
108 } 108 }
109 } 109 }
110 110
111 } // namespace WebCore 111 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/CustomElementWrapper.cpp ('k') | Source/core/dom/ContainerNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698