Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4318)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java

Issue 2903293002: [Android] Omnibox Placeholder Experiment (Closed)
Patch Set: cache experiment group instead of hint text Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
index eb5eaa25391250900ac039512b36c438743c0f43..23e88f2e1c0bace6cfd2900552d52fdecb612f09 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
@@ -58,6 +58,8 @@ public class ChromePreferenceManager {
private static final String SUCCESS_UPLOAD_SUFFIX = "_crash_success_upload";
private static final String FAILURE_UPLOAD_SUFFIX = "_crash_failure_upload";
+ private static final String OMNIBOX_PLACEHOLDER_KEY = "omnibox-placeholder";
mdjones 2017/05/30 17:34:08 nit: omnibox-placeholder-group
huayinz 2017/05/30 18:19:26 Done.
+
private static ChromePreferenceManager sPrefs;
private final SharedPreferences mSharedPreferences;
@@ -419,6 +421,22 @@ public class ChromePreferenceManager {
}
/**
+ * Set group of omnibox placeholder experiment
+ * @param hint Hint text to show on url bar
+ */
+ public void setOmniboxPlaceholder(String hint) {
+ writeString(OMNIBOX_PLACEHOLDER_KEY, hint);
+ }
+
+ /**
+ * Get group of omnibox placeholder experiment
+ * @return String of omnibox placeholder experiment group name, null if not set
+ */
+ public String getOmniboxPlaceholder() {
+ return mSharedPreferences.getString(OMNIBOX_PLACEHOLDER_KEY, null);
+ }
+
+ /**
* Writes the given int value to the named shared preference.
* @param key The name of the preference to modify.
* @param value The new value for the preference.

Powered by Google App Engine
This is Rietveld 408576698