chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 2903293002: [Android] Omnibox Placeholder Experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2903293002: [Android] Omnibox Placeholder Experiment (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBarFieldTrial.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index febb5cf6a72e46ad9024842389a1f4d7dfd7c226..67f76b5edd29c98ae47125dec082064f503e708b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -38,6 +38,7 @@ import org.chromium.chrome.browser.ntp.NewTabPage.OnSearchBoxScrollListener;

import org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter;

import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

+import org.chromium.chrome.browser.omnibox.UrlBarFieldTrial;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.suggestions.DestructionObserver;

import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;

@@ -337,7 +338,7 @@ public class NewTabPageView extends FrameLayout implements TileGroup.Observer {

searchBoxTextView.setCompoundDrawables(null, null, null, null);

}

- String hintText = getResources().getString(R.string.search_or_type_url);

+ String hintText = UrlBarFieldTrial.getUrlBarHint();

if (!DeviceFormFactor.isTablet()) {

searchBoxTextView.setHint(hintText);

} else {