Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1936)

Unified Diff: net/cert/internal/verify_certificate_chain_pkits_unittest.cc

Issue 2903283002: Add policies support to VerifyCertificateChain(). (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/verify_certificate_chain_pkits_unittest.cc
diff --git a/net/cert/internal/verify_certificate_chain_pkits_unittest.cc b/net/cert/internal/verify_certificate_chain_pkits_unittest.cc
index 8c16a3a6edb3d5b06fa6b5c96ba69be43d6af13f..a664dd369e527060f51112ae20a8e321af0a9899 100644
--- a/net/cert/internal/verify_certificate_chain_pkits_unittest.cc
+++ b/net/cert/internal/verify_certificate_chain_pkits_unittest.cc
@@ -78,9 +78,11 @@ class VerifyCertificateChainPkitsTestDelegate {
der::GeneralizedTime time = {2011, 4, 15, 0, 0, 0};
CertPathErrors path_errors;
- VerifyCertificateChain(input_chain, CertificateTrust::ForTrustAnchor(),
- &signature_policy, time, KeyPurpose::ANY_EKU,
- &path_errors);
+ VerifyCertificateChain(
+ input_chain, CertificateTrust::ForTrustAnchor(), &signature_policy,
+ time, KeyPurpose::ANY_EKU, settings.initial_explicit_policy,
+ settings.initial_policy_set, settings.initial_policy_mapping_inhibit,
+ settings.initial_inhibit_any_policy, &path_errors);
// TODO(crbug.com/634443): Test errors on failure?
return !path_errors.ContainsHighSeverityErrors();
@@ -204,6 +206,21 @@ INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
PkitsTest07KeyUsage,
VerifyCertificateChainPkitsTestDelegate);
INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
+ PkitsTest08CertificatePolicies,
+ VerifyCertificateChainPkitsTestDelegate);
+INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
+ PkitsTest09RequireExplicitPolicy,
+ VerifyCertificateChainPkitsTestDelegate);
+INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
+ PkitsTest10PolicyMappings,
+ VerifyCertificateChainPkitsTestDelegate);
+INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
+ PkitsTest11InhibitPolicyMapping,
+ VerifyCertificateChainPkitsTestDelegate);
+INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
+ PkitsTest12InhibitAnyPolicy,
+ VerifyCertificateChainPkitsTestDelegate);
+INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
PkitsTest13NameConstraints,
VerifyCertificateChainPkitsTestDelegate);
INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
@@ -214,8 +231,4 @@ INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
// PkitsTest05VerifyingPathswithSelfIssuedCertificates,
// PkitsTest14DistributionPoints, PkitsTest15DeltaCRLs
-// TODO(mattm): Certificate Policies support: PkitsTest08CertificatePolicies,
-// PkitsTest09RequireExplicitPolicy PkitsTest10PolicyMappings,
-// PkitsTest11InhibitPolicyMapping, PkitsTest12InhibitAnyPolicy
-
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698