Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ios/chrome/browser/ui/payments/payment_request_view_controller.mm

Issue 2903273002: Fixes formatting of the signed-in setting string on iOS. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/payments/payment_request_view_controller.mm
diff --git a/ios/chrome/browser/ui/payments/payment_request_view_controller.mm b/ios/chrome/browser/ui/payments/payment_request_view_controller.mm
index 1c825fbc85621f1c8d1f4f1287296e51554407b1..7826e26bb7e6aacceedc05b1c593de869d58a90a 100644
--- a/ios/chrome/browser/ui/payments/payment_request_view_controller.mm
+++ b/ios/chrome/browser/ui/payments/payment_request_view_controller.mm
@@ -6,7 +6,6 @@
#include "base/mac/foundation_util.h"
-#include "base/strings/stringprintf.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "components/autofill/core/browser/autofill_data_util.h"
@@ -377,12 +376,10 @@ typedef NS_ENUM(NSInteger, ItemType) {
footer.text =
l10n_util::GetNSString(IDS_PAYMENTS_CARD_AND_ADDRESS_SETTINGS);
} else if ([[_dataSource authenticatedAccountName] length]) {
- const std::string unformattedString = l10n_util::GetStringUTF8(
- IDS_PAYMENTS_CARD_AND_ADDRESS_SETTINGS_SIGNED_IN);
- const std::string accountName =
- base::SysNSStringToUTF8([_dataSource authenticatedAccountName]);
- const std::string formattedString =
- base::StringPrintf(unformattedString.c_str(), accountName.c_str());
+ const base::string16 accountName =
+ base::SysNSStringToUTF16([_dataSource authenticatedAccountName]);
+ const std::string formattedString = l10n_util::GetStringFUTF8(
+ IDS_PAYMENTS_CARD_AND_ADDRESS_SETTINGS_SIGNED_IN, accountName);
footer.text = base::SysUTF8ToNSString(formattedString);
} else {
footer.text = l10n_util::GetNSString(
« no previous file with comments | « ios/chrome/browser/ui/payments/BUILD.gn ('k') | ios/chrome/browser/ui/payments/payment_request_view_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698