Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2903243002: Add type inference logic for cascade expressions. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -34 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 3 chunks +5 lines, -33 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 3 chunks +81 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/constructors_infer_from_arguments.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paul Berry
3 years, 7 months ago (2017-05-25 12:52:58 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-25 14:17:16 UTC) #3
ahe
lgtm It'll create a conflict for me, I think. But I'll manage :-)
3 years, 7 months ago (2017-05-25 14:22:51 UTC) #5
Paul Berry
3 years, 7 months ago (2017-05-25 16:30:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
560cf61b3b51d82dd11777ff042b4ec31c871444 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698