Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2903183002: [Devtools] Moved preserve log to a setting (Closed)
Patch Set: [Devtools] Moved preserve log to a setting Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
index 4546ccc77dca90e6045515668afe166bcf188215..85b28e5d6d0f52ef1b1fa011e813566e2f927992 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
@@ -173,12 +173,10 @@ Network.NetworkPanel = class extends UI.Panel {
}
this._panelToolbar.appendSeparator();
-
- this._preserveLogCheckbox = new UI.ToolbarCheckbox(
- Common.UIString('Preserve log'), Common.UIString('Do not clear log on page reload / navigation'));
- this._preserveLogCheckbox.inputElement.addEventListener(
- 'change', this._onPreserveLogCheckboxChanged.bind(this), false);
- this._panelToolbar.appendToolbarItem(this._preserveLogCheckbox);
+ this._preserveLogSetting = Common.moduleSetting('network.preserve-log');
+ this._panelToolbar.appendToolbarItem(new UI.ToolbarSettingCheckbox(
+ this._preserveLogSetting, Common.UIString('Do not clear log on page reload / navigation'),
+ Common.UIString('Preserve log')));
this._disableCacheCheckbox = new UI.ToolbarSettingCheckbox(
Common.moduleSetting('cacheDisabled'), Common.UIString('Disable cache (while DevTools is open)'),
@@ -203,7 +201,7 @@ Network.NetworkPanel = class extends UI.Panel {
}
_toggleRecording() {
- if (!this._preserveLogCheckbox.checked() && !this._toggleRecordAction.toggled())
+ if (!this._preserveLogSetting.get() && !this._toggleRecordAction.toggled())
this._reset();
this._toggleRecord(!this._toggleRecordAction.toggled());
}
@@ -241,13 +239,6 @@ Network.NetworkPanel = class extends UI.Panel {
}
/**
- * @param {!Event} event
- */
- _onPreserveLogCheckboxChanged(event) {
- this._networkLogView.setPreserveLog(this._preserveLogCheckbox.checked());
- }
-
- /**
* @param {!Common.Event} event
*/
_onClearButtonClicked(event) {
@@ -267,7 +258,7 @@ Network.NetworkPanel = class extends UI.Panel {
* @param {!Common.Event} event
*/
_willReloadPage(event) {
- if (!this._preserveLogCheckbox.checked())
+ if (!this._preserveLogSetting.get())
this._reset();
this._toggleRecord(true);
if (this._pendingStopTimer) {

Powered by Google App Engine
This is Rietveld 408576698