Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2903153006: Treat type inference context `dynamic` as equivalent to an empty context. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Treat type inference context `dynamic` as equivalent to an empty context. This replicates analyzer behavior. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3c730528fcd34d94a9f9eb2523a90cea72625901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downward_inference_fixes_no_upwards_errors.dart View 2 chunks +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/downward_inference_fixes_no_upwards_errors.dart.strong.expect View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-26 18:16:00 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-26 18:19:27 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-26 18:26:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c730528fcd34d94a9f9eb2523a90cea72625901 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698