[IndexedDB] Adding uma for transaction aborts

content/browser/indexed_db/indexed_db_transaction.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_transaction.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
+#include "base/metrics/histogram_macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 #include "content/browser/indexed_db/indexed_db_cursor.h"
 #include "content/browser/indexed_db/indexed_db_database.h"
 #include "content/browser/indexed_db/indexed_db_database_callbacks.h"
 #include "content/browser/indexed_db/indexed_db_tracing.h"
 #include "content/browser/indexed_db/indexed_db_transaction_coordinator.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseException.h"
 #include "third_party/leveldatabase/env_chromium.h"
 
 namespace content {
 
 namespace {
 
 const int64_t kInactivityTimeoutPeriodSeconds = 60;
 
 // Helper for posting a task to call IndexedDBTransaction::Commit when we know
 // the transaction had no requests and therefore the commit must succeed.
 void CommitUnused(base::WeakPtr<IndexedDBTransaction> transaction) {
   if (!transaction)
     return;
   leveldb::Status status = transaction->Commit();
   DCHECK(status.ok());
 }
 
+// Used for UMA metrics - do not change values.
+enum UmaIDBException {
+  UmaIDBExceptionUnknownError = 0,
+  UmaIDBExceptionConstraintError,

[jsbell, 2017/05/25 17:08:58]

Give all of these explicit values since they are used in UMA.

[dmurph, 2017/05/25 17:33:08]

Done.

+  UmaIDBExceptionDataError,
+  UmaIDBExceptionVersionError,
+  UmaIDBExceptionAbortError,
+  UmaIDBExceptionQuotaError,
+  UmaIDBExceptionTimeoutError,
+  UmaIDBExceptionExclusiveMaxValue
+};
+
+// Used for UMA metrics - do not change mappings.
+UmaIDBException TranslateExceptionCodeToUmaEnum(uint16_t code) {

[jsbell, 2017/05/25 17:08:58]

Could drop 'Translate' from the name here, but it's fine.

[dmurph, 2017/05/25 17:33:08]

Done.

+  switch (code) {
+    case blink::kWebIDBDatabaseExceptionUnknownError:
+      return UmaIDBExceptionUnknownError;
+    case blink::kWebIDBDatabaseExceptionConstraintError:
+      return UmaIDBExceptionConstraintError;
+    case blink::kWebIDBDatabaseExceptionDataError:
+      return UmaIDBExceptionDataError;
+    case blink::kWebIDBDatabaseExceptionVersionError:
+      return UmaIDBExceptionVersionError;
+    case blink::kWebIDBDatabaseExceptionAbortError:
+      return UmaIDBExceptionAbortError;
+    case blink::kWebIDBDatabaseExceptionQuotaError:
+      return UmaIDBExceptionQuotaError;
+    case blink::kWebIDBDatabaseExceptionTimeoutError:
+      return UmaIDBExceptionTimeoutError;
+    default:
+      NOTREACHED();
+  }
+  return UmaIDBExceptionUnknownError;
+}
+
 }  // namespace
 
 IndexedDBTransaction::TaskQueue::TaskQueue() {}
 IndexedDBTransaction::TaskQueue::~TaskQueue() { clear(); }
 
 void IndexedDBTransaction::TaskQueue::clear() {
   while (!queue_.empty())
     queue_.pop();
 }
 
@@ skipping 96 matching lines @@
   Abort(IndexedDBDatabaseError(blink::kWebIDBDatabaseExceptionUnknownError,
                                "Internal error (unknown cause)"));
 }
 
 void IndexedDBTransaction::Abort(const IndexedDBDatabaseError& error) {
   IDB_TRACE1("IndexedDBTransaction::Abort", "txn.id", id());
   DCHECK(!processing_event_queue_);
   if (state_ == FINISHED)
     return;
 
+  UMA_HISTOGRAM_ENUMERATION("WebCore.IndexedDB.TransactionAbortReason",
+                            TranslateExceptionCodeToUmaEnum(error.code()),
+                            UmaIDBExceptionExclusiveMaxValue);
+
   timeout_timer_.Stop();
 
   state_ = FINISHED;
   should_process_queue_ = false;
 
   if (backing_store_transaction_begun_)
     transaction_->Rollback();
 
   // Run the abort tasks, if any.
   while (!abort_task_stack_.empty())
@@ skipping 355 matching lines @@
 
 ::indexed_db::mojom::ObserverChangesPtr*
 IndexedDBTransaction::GetPendingChangesForConnection(int32_t connection_id) {
   auto it = connection_changes_map_.find(connection_id);
   if (it != connection_changes_map_.end())
     return &it->second;
   return nullptr;
 }
 
 }  // namespace content