Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: src/isolate.cc

Issue 290313004: Comment out %RunMicrotasks assert that triggers in mjsunit tests (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index a07451a9bed2ffc3f375b5b38b533626a9b9529f..99af8fad36f56f18f5d28516544a2680496b1045 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2264,7 +2264,12 @@ void Isolate::EnqueueMicrotask(Handle<JSFunction> microtask) {
void Isolate::RunMicrotasks() {
- ASSERT(handle_scope_implementer()->CallDepthIsZero());
+ // TODO(adamk): This ASSERT triggers in mjsunit tests which
+ // call the %RunMicrotasks runtime function. But it should
+ // never happen outside of tests, so it would be nice to
+ // uncomment it.
+ //
+ // ASSERT(handle_scope_implementer()->CallDepthIsZero());
// Increase call depth to prevent recursive callbacks.
handle_scope_implementer()->IncrementCallDepth();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698