Use RecalcStyleDeferred for inspector style changes.

Use RecalcStyleDeferred for inspector style changes.

I could not find a reason why it needs to be immediate and all tests seem to
still pass.

R=pfeldman@chromium.org,ojan@chromium.org
BUG=374162
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174273

[rune, 2014-05-18 10:28:43]

@pfeldman: do you know about anything that could possibly break which is not
already covered by the current layout tests?

https://codereview.chromium.org/290313002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/290313002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorPageAgent.cpp:1228: document->updateLayout();

I don't think this updateLayout() call needs to be here. We should be more
explicit about why, when we need an updated layout.

[pfeldman, 2014-05-18 17:43:13]

I suspect that one of them might be needed.
+apavlov for InspectorStyleSheet
+dgozman for emulation

[ojan, 2014-05-18 17:50:38]

lgtm pending approval from devtools folks.

https://codereview.chromium.org/290313002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/290313002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorPageAgent.cpp:1228: document->updateLayout();
On 2014/05/18 10:28:43, rune wrote:
> 
> I don't think this updateLayout() call needs to be here. We should be more
> explicit about why, when we need an updated layout.

My guess is that it's there to trigger this code:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

That said, I don't see why we would need to trigger that code.

[rune, 2014-05-19 07:19:21]

On 2014/05/18 17:43:13, pfeldman wrote:
> I suspect that one of them might be needed.
> +apavlov for InspectorStyleSheet
> +dgozman for emulation

I've used the inspector in content_shell to trigger all those three instances
and it works as I'd expect.

[dgozman, 2014-05-19 08:31:12]

InspectorPageAgent.cpp lgtm

[lushnikov, 2014-05-19 09:21:20]

On 2014/05/19 09:11:14, apavlov wrote:

InspectorStyleSheet.cpp lgtm

[rune, 2014-05-19 09:26:36]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-05-19 09:26:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/290313002/1

[vsevik, 2014-05-19 09:32:39]

https://codereview.chromium.org/290313002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorStyleSheet.cpp (right):

https://codereview.chromium.org/290313002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorStyleSheet.cpp:1003:
m_pageStyleSheet->ownerDocument()->styleResolverChanged(RecalcStyleDeferred,
FullStyleUpdate);
This is needed to make sure StyleSheetAdded/Removed events are dispatched inside
setText  processing in case setText changes @import in stylesheet.
We need to evaluate possible consequences of this change,

[vsevik, 2014-05-19 09:32:52]

The CQ bit was unchecked by vsevik@chromium.org

[rune, 2014-05-19 11:14:55]

On 2014/05/19 09:32:39, vsevik wrote:
>
https://codereview.chromium.org/290313002/diff/1/Source/core/inspector/Inspec...
> File Source/core/inspector/InspectorStyleSheet.cpp (right):
> 
>
https://codereview.chromium.org/290313002/diff/1/Source/core/inspector/Inspec...
> Source/core/inspector/InspectorStyleSheet.cpp:1003:
> m_pageStyleSheet->ownerDocument()->styleResolverChanged(RecalcStyleDeferred,
> FullStyleUpdate);
> This is needed to make sure StyleSheetAdded/Removed events are dispatched
inside
> setText  processing in case setText changes @import in stylesheet.
> We need to evaluate possible consequences of this change,

Calling InspectorInstrumentation::activeStyleSheetsUpdated happens as part of
StyleEngine::updateActiveStyleSheets which is called from
StyleEngine::resolverChanged regardless of whether we use deferred or immediate
recalc, so that should be fine, no?

Another interesting thing I found while debugging is that we're triggering
styleResolverChanged from the RuleMutationScopes right above, so I don't know
why that extra styleResolverChanged would be necessary.

[vsevik, 2014-05-19 11:31:55]

Ok, this seems fine.

[vsevik, 2014-05-19 11:31:59]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-05-19 11:32:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/290313002/1

[commit-bot: I haz the power, 2014-05-19 12:18:53]

Change committed as 174273