Issue 290303002: Revert of Use real PlatformSupport in content unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 290303002: Revert of Use real PlatformSupport in content unit tests (Closed)

Created:
6 years, 7 months ago by enne (OOO)

Modified:
6 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews, darin-cc_chromium.org, jam, benwells

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Use real PlatformSupport in content unit tests (https://codereview.chromium.org/287043002/) Reason for revert: Caused mac_valgrind issues because TestWebKitPlatformSupport isn't cleaning up after itself properly Original issue's description: > Use real PlatformSupport in content unit tests > > Once all pages are force composited by default, this allows these tests > to not explode when trying to create GraphicsLayers because of a lack of > Platform::compositorSupport. > > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270894 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271229 TBR=piman@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271261

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -19 lines)			Patch
M	content/content_tests.gypi	View	5 chunks	+12 lines, -12 lines	0 comments	Download
M	content/public/test/unittest_test_suite.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/public/test/unittest_test_suite.cc	View	1 chunk	+24 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

enne (OOO)

Created Revert of Use real PlatformSupport in content unit tests

6 years, 7 months ago (2014-05-17 20:12:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/290303002/1

6 years, 7 months ago (2014-05-17 20:12:52 UTC) #2

Message was sent while issue was closed.

Change committed as 271261