telemetry/telemetry/internal/story_runner_unittest.py - Issue 2903023002: [Telemetry] Do not have benchmarks validate story name in expectations during runs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/story_runner_unittest.py

Issue 2903023002: [Telemetry] Do not have benchmarks validate story name in expectations during runs. (Closed)

Patch Set: [Telemetry] Do not have benchmarks validate story name in expectations during runs. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/story_runner_unittest.py

diff --git a/telemetry/telemetry/internal/story_runner_unittest.py b/telemetry/telemetry/internal/story_runner_unittest.py

index 37ef0d18f598d55c5bcf55223814fb45bb384ce2..ec3f9e909296033310716cc6279f42ce7b36b904 100644

--- a/telemetry/telemetry/internal/story_runner_unittest.py

+++ b/telemetry/telemetry/internal/story_runner_unittest.py

@@ -1224,8 +1224,7 @@ class StoryRunnerTest(unittest.TestCase):

try:

options.output_dir = tmp_path

rc = story_runner.RunBenchmark(fake_benchmark, options)

- # The exception from not having a matching name is caught and the return

- # code is set to a failure code.

- self.assertEqual(rc, 255)

+ # Test should return 0 since only error messages are logged.

+ self.assertEqual(rc, 0)

finally:

shutil.rmtree(tmp_path)