Chromium Code Reviews
Help | Chromium Project | Sign in
(225)

Issue 2903008: Expose cookie get/set to pyauto (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Alyssa
Modified:
4 years ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Expose cookie get/set to pyauto Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52522

Patch Set 1 : Initial #

Total comments: 6

Patch Set 2 : Reviewed #

Total comments: 4

Patch Set 3 : Revised #

Total comments: 10

Patch Set 4 : Revised #

Total comments: 15

Patch Set 5 : Revised #

Patch Set 6 : Added TODO #

Total comments: 1

Patch Set 7 : Final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/functional/cookies.py View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 1 2 3 4 5 6 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 16 (0 generated)
Alyssa
Functionality was already in AutomationProvider - just exposed it to PyAuto.
4 years, 10 months ago (2010-07-12 23:35:32 UTC) #1
Nirnimesh
Please update description to something like: "Expose cookie get/set to pyauto" http://codereview.chromium.org/2903008/diff/2001/3002 File chrome/test/functional/cookies.py (right): ...
4 years, 10 months ago (2010-07-13 00:00:44 UTC) #2
Paweł Hajdan Jr.
Drive-by with minor automation comments. No need to wait for another review by me. http://codereview.chromium.org/2903008/diff/8001/6004 ...
4 years, 10 months ago (2010-07-13 03:34:07 UTC) #3
Alyssa
http://codereview.chromium.org/2903008/diff/2001/3002 File chrome/test/functional/cookies.py (right): http://codereview.chromium.org/2903008/diff/2001/3002#newcode13 chrome/test/functional/cookies.py:13: """Tests that getting/setting cookies works correctly.""" On 2010/07/13 00:00:46, ...
4 years, 10 months ago (2010-07-13 18:14:46 UTC) #4
Nirnimesh
http://codereview.chromium.org/2903008/diff/11001/12004 File chrome/test/pyautolib/pyautolib.h (right): http://codereview.chromium.org/2903008/diff/11001/12004#newcode158 chrome/test/pyautolib/pyautolib.h:158: int tab_index); move all args to this line, or ...
4 years, 10 months ago (2010-07-13 18:53:14 UTC) #5
Alyssa
http://codereview.chromium.org/2903008/diff/11001/12004 File chrome/test/pyautolib/pyautolib.h (right): http://codereview.chromium.org/2903008/diff/11001/12004#newcode158 chrome/test/pyautolib/pyautolib.h:158: int tab_index); On 2010/07/13 18:53:14, Nirnimesh wrote: > move ...
4 years, 10 months ago (2010-07-13 19:07:02 UTC) #6
Nirnimesh
LGTM http://codereview.chromium.org/2903008/diff/22001/1010 File chrome/test/pyautolib/pyautolib.i (right): http://codereview.chromium.org/2903008/diff/22001/1010#newcode319 chrome/test/pyautolib/pyautolib.i:319: bool SetCookie(const GURL& cookie_url, const std::string& value, You ...
4 years, 10 months ago (2010-07-13 19:12:00 UTC) #7
Paweł Hajdan Jr.
http://codereview.chromium.org/2903008/diff/22001/1008 File chrome/test/pyautolib/pyautolib.cc (right): http://codereview.chromium.org/2903008/diff/22001/1008#newcode307 chrome/test/pyautolib/pyautolib.cc:307: if (!browser_proxy.get()) nit: Shouldn't you EXPECT_TRUE(browser_proxy) above this final ...
4 years, 10 months ago (2010-07-13 19:58:29 UTC) #8
Nirnimesh
http://codereview.chromium.org/2903008/diff/22001/1008 File chrome/test/pyautolib/pyautolib.cc (right): http://codereview.chromium.org/2903008/diff/22001/1008#newcode322 chrome/test/pyautolib/pyautolib.cc:322: return cookie_val; On 2010/07/13 19:58:29, Paweł Hajdan Jr. wrote: ...
4 years, 10 months ago (2010-07-13 20:14:33 UTC) #9
Alyssa
http://codereview.chromium.org/2903008/diff/22001/1008 File chrome/test/pyautolib/pyautolib.cc (right): http://codereview.chromium.org/2903008/diff/22001/1008#newcode307 chrome/test/pyautolib/pyautolib.cc:307: if (!browser_proxy.get()) On 2010/07/13 19:58:29, Paweł Hajdan Jr. wrote: ...
4 years, 10 months ago (2010-07-14 00:51:56 UTC) #10
Paweł Hajdan Jr.
http://codereview.chromium.org/2903008/diff/22001/1008 File chrome/test/pyautolib/pyautolib.cc (right): http://codereview.chromium.org/2903008/diff/22001/1008#newcode322 chrome/test/pyautolib/pyautolib.cc:322: return cookie_val; On 2010/07/13 20:14:33, Nirnimesh wrote: > On ...
4 years, 10 months ago (2010-07-14 00:55:33 UTC) #11
Nirnimesh
http://codereview.chromium.org/2903008/diff/22001/1008 File chrome/test/pyautolib/pyautolib.cc (right): http://codereview.chromium.org/2903008/diff/22001/1008#newcode322 chrome/test/pyautolib/pyautolib.cc:322: return cookie_val; On 2010/07/14 00:55:33, Paweł Hajdan Jr. wrote: ...
4 years, 10 months ago (2010-07-14 01:16:57 UTC) #12
Paweł Hajdan Jr.
http://codereview.chromium.org/2903008/diff/22001/1008 File chrome/test/pyautolib/pyautolib.cc (right): http://codereview.chromium.org/2903008/diff/22001/1008#newcode322 chrome/test/pyautolib/pyautolib.cc:322: return cookie_val; On 2010/07/14 01:16:59, Nirnimesh wrote: > Ideally, ...
4 years, 10 months ago (2010-07-14 01:19:39 UTC) #13
Nirnimesh
http://codereview.chromium.org/2903008/diff/22001/1008 File chrome/test/pyautolib/pyautolib.cc (right): http://codereview.chromium.org/2903008/diff/22001/1008#newcode322 chrome/test/pyautolib/pyautolib.cc:322: return cookie_val; On 2010/07/14 01:19:39, Paweł Hajdan Jr. wrote: ...
4 years, 10 months ago (2010-07-14 01:37:24 UTC) #14
Alyssa
I added a TODO. Pawel - Did you have any other comments for me or ...
4 years, 10 months ago (2010-07-14 17:52:08 UTC) #15
Paweł Hajdan Jr.
4 years, 10 months ago (2010-07-14 17:53:51 UTC) #16
LGTM with a nit.

http://codereview.chromium.org/2903008/diff/31001/3008
File chrome/test/pyautolib/pyautolib.cc (right):

http://codereview.chromium.org/2903008/diff/31001/3008#newcode323
chrome/test/pyautolib/pyautolib.cc:323: // TODO: figure out a way to
unambiguously report error condition.
nit: TODO(phajdan.jr)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be