Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2902933002: Verify all files in the request body are accessible by the renderer process. (Closed)
Patch Set: Fixes based on Nick's review. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 943 matching lines...) Expand 10 before | Expand all | Expand 10 after
954 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 954 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
955 955
956 // Called by |beforeunload_timeout_| when the beforeunload timeout fires. 956 // Called by |beforeunload_timeout_| when the beforeunload timeout fires.
957 void BeforeUnloadTimeout(); 957 void BeforeUnloadTimeout();
958 958
959 // Called when a navigation commits succesfully to |url|. This will update 959 // Called when a navigation commits succesfully to |url|. This will update
960 // |last_committed_site_url_| if it's not equal to the site url corresponding 960 // |last_committed_site_url_| if it's not equal to the site url corresponding
961 // to |url|. 961 // to |url|.
962 void SetLastCommittedSiteUrl(const GURL& url); 962 void SetLastCommittedSiteUrl(const GURL& url);
963 963
964 // Ensures that the upload parameters sent by the renderer process are
965 // valid and any files specified are allowed for access.
966 bool ValidateUploadParams(const CommonNavigationParams& common_params);
967
964 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a 968 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
965 // refcount that calls Shutdown when it reaches zero. This allows each 969 // refcount that calls Shutdown when it reaches zero. This allows each
966 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring 970 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
967 // we have a RenderViewHost for each RenderFrameHost. 971 // we have a RenderViewHost for each RenderFrameHost.
968 // TODO(creis): RenderViewHost will eventually go away and be replaced with 972 // TODO(creis): RenderViewHost will eventually go away and be replaced with
969 // some form of page context. 973 // some form of page context.
970 RenderViewHostImpl* const render_view_host_; 974 RenderViewHostImpl* const render_view_host_;
971 975
972 RenderFrameHostDelegate* const delegate_; 976 RenderFrameHostDelegate* const delegate_;
973 977
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
1243 1247
1244 // NOTE: This must be the last member. 1248 // NOTE: This must be the last member.
1245 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 1249 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
1246 1250
1247 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 1251 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
1248 }; 1252 };
1249 1253
1250 } // namespace content 1254 } // namespace content
1251 1255
1252 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 1256 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/browser_side_navigation_browsertest.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698