Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2902933002: Verify all files in the request body are accessible by the renderer process. (Closed)
Patch Set: Remove NOTREACHED as tests exercise this codepath. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 937 matching lines...) Expand 10 before | Expand all | Expand 10 after
948 const base::string16& user_input); 948 const base::string16& user_input);
949 949
950 // Returns ownership of the NavigationHandle associated with a navigation that 950 // Returns ownership of the NavigationHandle associated with a navigation that
951 // just committed. 951 // just committed.
952 std::unique_ptr<NavigationHandleImpl> TakeNavigationHandleForCommit( 952 std::unique_ptr<NavigationHandleImpl> TakeNavigationHandleForCommit(
953 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 953 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
954 954
955 // Called by |beforeunload_timeout_| when the beforeunload timeout fires. 955 // Called by |beforeunload_timeout_| when the beforeunload timeout fires.
956 void BeforeUnloadTimeout(); 956 void BeforeUnloadTimeout();
957 957
958 // Ensures that the upload parameters sent by the renderer process are
ncarter (slow) 2017/05/24 20:06:19 "Ensures that" -> "Returns true if".
959 // valid and any files specified are allowed for access.
960 bool ValidateUploadParams(const CommonNavigationParams& common_params);
961
958 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a 962 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
959 // refcount that calls Shutdown when it reaches zero. This allows each 963 // refcount that calls Shutdown when it reaches zero. This allows each
960 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring 964 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
961 // we have a RenderViewHost for each RenderFrameHost. 965 // we have a RenderViewHost for each RenderFrameHost.
962 // TODO(creis): RenderViewHost will eventually go away and be replaced with 966 // TODO(creis): RenderViewHost will eventually go away and be replaced with
963 // some form of page context. 967 // some form of page context.
964 RenderViewHostImpl* const render_view_host_; 968 RenderViewHostImpl* const render_view_host_;
965 969
966 RenderFrameHostDelegate* const delegate_; 970 RenderFrameHostDelegate* const delegate_;
967 971
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
1233 1237
1234 // NOTE: This must be the last member. 1238 // NOTE: This must be the last member.
1235 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 1239 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
1236 1240
1237 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 1241 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
1238 }; 1242 };
1239 1243
1240 } // namespace content 1244 } // namespace content
1241 1245
1242 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 1246 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698