Issue 290293002: clenaup: Removed deprecated GetInstalledExtension function from c/b/e/api

Issue 290293002: clenaup: Removed deprecated GetInstalledExtension function from c/b/e/api (Closed)

Created:
6 years, 7 months ago by limasdf

Modified:
6 years, 7 months ago

Reviewers:
Devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Removed deprecated GetInstalledExtension function from c/b/e/api/* and removed unwanted extension:: prefix. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272572

Patch Set 2 : rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -35 lines)			Patch
M	chrome/browser/extensions/api/declarative/rules_cache_delegate.cc	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_content/content_action.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_content/content_rules_registry.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/api/developer_private/developer_private_api.cc	View	1	11 chunks	+23 lines, -19 lines	0 comments	Download
M	chrome/browser/extensions/api/management/management_api.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Devlin

lgtm with two nits. https://codereview.chromium.org/290293002/diff/70001/chrome/browser/extensions/api/declarative/rules_cache_delegate.cc File chrome/browser/extensions/api/declarative/rules_cache_delegate.cc (right): https://codereview.chromium.org/290293002/diff/70001/chrome/browser/extensions/api/declarative/rules_cache_delegate.cc#newcode217 chrome/browser/extensions/api/declarative/rules_cache_delegate.cc:217: ExtensionRegistry* registry = ExtensionRegistry::Get(profile_); Could ...

6 years, 7 months ago (2014-05-22 22:09:11 UTC) #2

limasdf

Thanks for the review. https://codereview.chromium.org/290293002/diff/70001/chrome/browser/extensions/api/declarative/rules_cache_delegate.cc File chrome/browser/extensions/api/declarative/rules_cache_delegate.cc (right): https://codereview.chromium.org/290293002/diff/70001/chrome/browser/extensions/api/declarative/rules_cache_delegate.cc#newcode217 chrome/browser/extensions/api/declarative/rules_cache_delegate.cc:217: ExtensionRegistry* registry = ExtensionRegistry::Get(profile_); On ...

6 years, 7 months ago (2014-05-23 15:19:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/290293002/90001

6 years, 7 months ago (2014-05-23 15:20:55 UTC) #5

Message was sent while issue was closed.

Change committed as 272572

Expand Messages | Collapse Messages