Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2902883003: DCHECK NeedsLayoutTreeUpdate in VisibleUnits::ComputeTextBounds() (Closed)

Created:
3 years, 7 months ago by yoichio
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DCHECK NeedsLayoutTreeUpdate in VisibleUnits::ComputeTextBounds() That's because it traverses Layout tree. BUG= Review-Url: https://codereview.chromium.org/2902883003 Cr-Commit-Position: refs/heads/master@{#474617} Committed: https://chromium.googlesource.com/chromium/src/+/a161d3858abb3b14048fbbfc76d164f62dcdd15a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yoichio
3 years, 7 months ago (2017-05-25 08:27:28 UTC) #7
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-25 09:35:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902883003/1
3 years, 7 months ago (2017-05-25 09:35:53 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 09:40:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a161d3858abb3b14048fbbfc76d1...

Powered by Google App Engine
This is Rietveld 408576698