Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/renderer/media/webrtc/webrtc_media_stream_track_adapter.cc

Issue 2902733003: RemoteMediaStreamImpl using WebRtcMediaStreamTrackMap. (Closed)
Patch Set: "Must be invoked on the main thread." Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/webrtc_media_stream_track_adapter.cc
diff --git a/content/renderer/media/webrtc/webrtc_media_stream_track_adapter.cc b/content/renderer/media/webrtc/webrtc_media_stream_track_adapter.cc
index ea1e311d84ae1a722be898bd7f84df3545709da5..c4b2955c548f58101461dabf59104345b9beb1dd 100644
--- a/content/renderer/media/webrtc/webrtc_media_stream_track_adapter.cc
+++ b/content/renderer/media/webrtc/webrtc_media_stream_track_adapter.cc
@@ -17,7 +17,9 @@ WebRtcMediaStreamTrackAdapter::CreateLocalTrackAdapter(
PeerConnectionDependencyFactory* factory,
const scoped_refptr<base::SingleThreadTaskRunner>& main_thread,
const blink::WebMediaStreamTrack& web_track) {
+ DCHECK(factory);
DCHECK(main_thread->BelongsToCurrentThread());
+ DCHECK(!web_track.IsNull());
scoped_refptr<WebRtcMediaStreamTrackAdapter> local_track_adapter(
new WebRtcMediaStreamTrackAdapter(factory, main_thread));
if (web_track.Source().GetType() == blink::WebMediaStreamSource::kTypeAudio) {
@@ -36,7 +38,8 @@ WebRtcMediaStreamTrackAdapter::CreateRemoteTrackAdapter(
PeerConnectionDependencyFactory* factory,
const scoped_refptr<base::SingleThreadTaskRunner>& main_thread,
webrtc::MediaStreamTrackInterface* webrtc_track) {
- DCHECK(factory->GetWebRtcSignalingThread()->BelongsToCurrentThread());
+ DCHECK(factory);
+ DCHECK(!main_thread->BelongsToCurrentThread());
DCHECK(webrtc_track);
scoped_refptr<WebRtcMediaStreamTrackAdapter> remote_track_adapter(
new WebRtcMediaStreamTrackAdapter(factory, main_thread));
@@ -163,7 +166,7 @@ void WebRtcMediaStreamTrackAdapter::InitializeLocalVideoTrack(
void WebRtcMediaStreamTrackAdapter::InitializeRemoteAudioTrack(
webrtc::AudioTrackInterface* webrtc_audio_track) {
- DCHECK(factory_->GetWebRtcSignalingThread()->BelongsToCurrentThread());
+ DCHECK(!main_thread_->BelongsToCurrentThread());
DCHECK(!is_initialized_);
DCHECK(webrtc_audio_track);
DCHECK_EQ(webrtc_audio_track->kind(),
@@ -179,7 +182,7 @@ void WebRtcMediaStreamTrackAdapter::InitializeRemoteAudioTrack(
void WebRtcMediaStreamTrackAdapter::InitializeRemoteVideoTrack(
webrtc::VideoTrackInterface* webrtc_video_track) {
- DCHECK(factory_->GetWebRtcSignalingThread()->BelongsToCurrentThread());
+ DCHECK(!main_thread_->BelongsToCurrentThread());
DCHECK(!is_initialized_);
DCHECK(webrtc_video_track);
DCHECK_EQ(webrtc_video_track->kind(),
@@ -256,7 +259,7 @@ void WebRtcMediaStreamTrackAdapter::DisposeRemoteVideoTrack() {
void WebRtcMediaStreamTrackAdapter::
UnregisterRemoteAudioTrackAdapterOnSignalingThread() {
- DCHECK(factory_->GetWebRtcSignalingThread()->BelongsToCurrentThread());
+ DCHECK(!main_thread_->BelongsToCurrentThread());
DCHECK(!is_initialized_);
DCHECK(remote_audio_track_adapter_);
remote_audio_track_adapter_->Unregister();

Powered by Google App Engine
This is Rietveld 408576698