Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 290273004: Don't pass --harmony-promises flag from gin to v8 (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
adamk
CC:
chromium-reviews
Visibility:
Public.

Description

Don't pass --harmony-promises flag from gin to v8 Promises are now enabled by default BUG=none R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gin/isolate_holder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-19 07:31:20 UTC) #1
adamk
lgtm
6 years, 7 months ago (2014-05-19 07:32:07 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-19 07:35:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/290273004/1
6 years, 7 months ago (2014-05-19 07:35:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 09:30:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 10:21:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154928)
6 years, 7 months ago (2014-05-19 10:21:47 UTC) #7
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-19 15:55:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/290273004/1
6 years, 7 months ago (2014-05-19 15:55:42 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 17:15:51 UTC) #10
Message was sent while issue was closed.
Change committed as 271410

Powered by Google App Engine
This is Rietveld 408576698