third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view.html - Issue 2902673003: Added a refresh database button on the IndexedDB view.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view.html

Issue 2902673003: Added a refresh database button on the IndexedDB view. (Closed)

Patch Set: Removed model and test line Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../inspector-test.js"></script>

	4 <script src="../resources-test.js"></script>

	5 <script src="../console-test.js"></script>

	6 <script src="indexeddb-test.js"></script>

	7 <script>

	8

	9 window.debugTest = true;

	10 async function test()

	11 {

	12 var databaseName = "testDatabase";

	13 var objectStoreName = "testObjectStore";

	14

	15 function createIndexedDB(callback) {
	dmurph 2017/05/23 21:22:05 See style guide: https://google.github.io/stylegui See style guide: https://google.github.io/styleguide/javascriptguide.xml#Function_Declarations... Please make the function a variable. kristipark 2017/05/26 01:09:28 Done. Show quoted text On 2017/05/23 21:22:05, dmurph wrote: > See style guide: > https://google.github.io/styleguide/javascriptguide.xml#Function_Declarations... > > Please make the function a variable. Done.
	16 var mainFrameId = InspectorTest.resourceTreeModel.mainFrame.id;

	17 var model = InspectorTest.mainTarget.model(Resources.IndexedDBModel);

	18 InspectorTest.createDatabase(mainFrameId, "testDatabase", () => {

	19 var event = model.addEventListener(Resources.IndexedDBModel.Events.D atabaseAdded, () => {

	20 Common.EventTarget.removeEventListeners([event]);

	21 callback();

	22 });

	23 });

	24 }

	25

	26 function createObjectStore(callback) {

	27 var mainFrameId = InspectorTest.resourceTreeModel.mainFrame.id;

	28 InspectorTest.createObjectStore(mainFrameId, databaseName, objectStoreNa me, "key", true, callback);

	29 }

	30

	31 function createObjectStoreIndex(callback) {

	32 var mainFrameId = InspectorTest.resourceTreeModel.mainFrame.id;

	33 InspectorTest.createObjectStoreIndex(mainFrameId, databaseName, objectSt oreName, "testIndex", "value", false, true, callback);

	34 }

	35

	36 function addIDBValue(callback) {

	37 InspectorTest.addIDBValue(callback, databaseName, objectStoreName, "test Value", "testKey");

	38 }

	39

	40 function dumpCurrentObjectStore() {

	41 InspectorTest.addResult("Current ObjectStore view:");

	42

	43 var objectStoreTreeElement = UI.panels.resources._sidebar.indexedDBListT reeElement.childAt(0).childAt(0);
	dmurph 2017/05/23 21:22:05 Can you iterate each object store? Can you iterate each object store? kristipark 2017/05/26 01:09:28 Done. Show quoted text On 2017/05/23 21:22:05, dmurph wrote: > Can you iterate each object store? Done.
	44 InspectorTest.addResult("Object store: " + objectStoreTreeElement.title) ;

	45 var entries = objectStoreTreeElement._view._entries;

	46 if (!entries.length) {

	47 InspectorTest.addResult(" (no entries)");

	48 } else {

	49 for (var j = 0; j < entries.length; ++j) {

	50 InspectorTest.addResult(" Key = " + entries[j].key + ", value = " + entries[j].value);

	51 }

	52 }

	53 }

	54

	55 await new Promise(createIndexedDB);

	56 await new Promise(createObjectStore);

	57 await new Promise(createObjectStoreIndex);

	58

	59 var databaseTreeElement = UI.panels.resources._sidebar.indexedDBListTreeElem ent.childAt(0);

	60 databaseTreeElement.onselect(false);

	61 InspectorTest.addResult("Created database view.");

	62 var objectstoreTreeElement = databaseTreeElement.childAt(0);

	63 objectstoreTreeElement.onselect(false);

	64 InspectorTest.addResult("Created data view.");

	65

	66 var databaseView = databaseTreeElement._view;

	67 var dataView = objectstoreTreeElement._view;

	68

	69 dumpCurrentObjectStore();

	70

	71 await new Promise(addIDBValue);

	72 InspectorTest.addResult("Added objectstore entry.");
	dmurph 2017/05/23 21:22:05 Can you also add another object store? - This migh Can you also add another object store? - This might mean you change how you're doing promises - consider having the function call return another function so you can specify the name: var createObjectStore = function(name) { return function(resolve) { var mainFrameId = InspectorTest.resourceTreeModel.mainFrame.id; InspectorTest.createObjectStore(mainFrameId, databaseName, name, "key", true, resolve); } } Then you can check that the object store tree list changes. kristipark 2017/05/26 01:09:28 Done. Show quoted text On 2017/05/23 21:22:05, dmurph wrote: > Can you also add another object store? - This might mean you change how you're > doing promises - consider having the function call return another function so > you can specify the name: > > var createObjectStore = function(name) { > return function(resolve) { > var mainFrameId = InspectorTest.resourceTreeModel.mainFrame.id; > InspectorTest.createObjectStore(mainFrameId, databaseName, name, "key", > true, resolve); > } > } > > Then you can check that the object store tree list changes. Done.
	73

	74 dumpCurrentObjectStore();

	75

	76 databaseView._refreshDatabase();

	77 InspectorTest.addResult("Refreshed database view.");

	78

	79 dumpCurrentObjectStore();

	80

	81 InspectorTest.completeTest();

	82 }

	83 </script>

	84 </head>

	85 <body onload="runTest()">

	86 <p>Tests refreshing the database information and data views.</p>

	87 </body>

	88 </html>

OLD	NEW