Get main frame and subframe AppCache loads to work.

content/browser/appcache/appcache_url_loader_request.cc

Index: content/browser/appcache/appcache_url_loader_request.cc
diff --git a/content/browser/appcache/appcache_url_loader_request.cc b/content/browser/appcache/appcache_url_loader_request.cc
index c85de02931073a2c9345c52a90e1c7a470b8934b..11c85ba497b80b8c979f9f8541e20730b2345d77 100644
--- a/content/browser/appcache/appcache_url_loader_request.cc
+++ b/content/browser/appcache/appcache_url_loader_request.cc
@@ -9,27 +9,27 @@ namespace content {
 
 // static
 std::unique_ptr<AppCacheURLLoaderRequest> AppCacheURLLoaderRequest::Create(
-    std::unique_ptr<ResourceRequest> request) {
+    const ResourceRequest& request) {
   return std::unique_ptr<AppCacheURLLoaderRequest>(
-      new AppCacheURLLoaderRequest(std::move(request)));
+      new AppCacheURLLoaderRequest(request));
 }
 
 AppCacheURLLoaderRequest::~AppCacheURLLoaderRequest() {}
 
 const GURL& AppCacheURLLoaderRequest::GetURL() const {
-  return request_->url;
+  return request_.url;
 }
 
 const std::string& AppCacheURLLoaderRequest::GetMethod() const {
-  return request_->method;
+  return request_.method;
 }
 
 const GURL& AppCacheURLLoaderRequest::GetFirstPartyForCookies() const {
-  return request_->first_party_for_cookies;
+  return request_.first_party_for_cookies;
 }
 
 const GURL AppCacheURLLoaderRequest::GetReferrer() const {
-  return request_->referrer;
+  return request_.referrer;
 }
 
 bool AppCacheURLLoaderRequest::IsSuccess() const {
@@ -54,11 +54,11 @@ std::string AppCacheURLLoaderRequest::GetResponseHeaderByName(
 }
 
 ResourceRequest* AppCacheURLLoaderRequest::GetResourceRequest() {
-  return request_.get();
+  return &request_;
 }
 
 AppCacheURLLoaderRequest::AppCacheURLLoaderRequest(
-    std::unique_ptr<ResourceRequest> request)
-    : request_(std::move(request)) {}
+    const ResourceRequest& request)
+    : request_(request) {}

[michaeln, 2017/06/09 01:48:30]

is this copy expensive? i see other loaders make a copy too

[ananta, 2017/06/09 04:48:19]

Shouldn't be too expensive I think. This is a pattern in the n/w service code.

 
 }  // namespace content