Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2555)

Unified Diff: content/browser/appcache/appcache_navigation_handle_core.cc

Issue 2902653002: Get main frame and subframe AppCache loads to work. (Closed)
Patch Set: Address portions of the review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_navigation_handle_core.cc
diff --git a/content/browser/appcache/appcache_navigation_handle_core.cc b/content/browser/appcache/appcache_navigation_handle_core.cc
index 83a6ccf484ba47bd18dadfa80130f28173faf58c..0ee0dcc0b832a4251f2da55edc6835d7735b97ac 100644
--- a/content/browser/appcache/appcache_navigation_handle_core.cc
+++ b/content/browser/appcache/appcache_navigation_handle_core.cc
@@ -50,8 +50,9 @@ AppCacheNavigationHandleCore::~AppCacheNavigationHandleCore() {
void AppCacheNavigationHandleCore::Initialize() {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK(precreated_host_.get() == nullptr);
- precreated_host_.reset(
- new AppCacheHost(appcache_host_id_, this, GetAppCacheService()));
+ precreated_host_.reset(new AppCacheHost(
+ appcache_host_id_, this,
+ static_cast<AppCacheServiceImpl*>(GetAppCacheService())));
DCHECK(g_appcache_handle_map.Get().find(appcache_host_id_) ==
g_appcache_handle_map.Get().end());
@@ -71,8 +72,8 @@ std::unique_ptr<AppCacheHost> AppCacheNavigationHandleCore::GetPrecreatedHost(
return std::unique_ptr<AppCacheHost>();
}
-AppCacheServiceImpl* AppCacheNavigationHandleCore::GetAppCacheService() {
- return static_cast<AppCacheServiceImpl*>(appcache_service_.get());
+ChromeAppCacheService* AppCacheNavigationHandleCore::GetAppCacheService() {
+ return appcache_service_.get();
}
void AppCacheNavigationHandleCore::OnCacheSelected(int host_id,

Powered by Google App Engine
This is Rietveld 408576698